HHH-19782 - Oracle support for locking across joins #10954
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java
# Conflicts: # hibernate-core/src/main/java/org/hibernate/sql/results/jdbc/internal/DeferredResultSetAccess.java
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| default RootGraphImplementor createRootGraph(SharedSessionContractImplementor session) { | ||
| if ( getRepresentationStrategy() instanceof EntityRepresentationStrategyMap mapRep ) { |
Check notice
Code scanning / CodeQL
Unread local variable Note
| final Map<Object, EntityDetails> entityDetailsMap = resolveEntityKeys( entityKeys, executionContext ); | ||
|
|
||
| entityMappingType.forEachAttributeMapping( (index, attributeMapping) -> { | ||
| if ( attributeMapping instanceof PluralAttributeMapping pluralAttributeMapping ) { |
Check notice
Code scanning / CodeQL
Unread local variable Note
|
|
||
| private final FollowOnLockingCreationStates creationStates; | ||
|
|
||
| private final List<Integer> statePositions = new ArrayList<>(); |
Check failure
Code scanning / CodeQL
Container contents are never accessed Error
| * @param jdbcConnection The JDBC Connection. | ||
| * @param executionContext Access to contextual information useful while executing. | ||
| */ | ||
| void performPostAction(StatementAccess jdbcStatementAccess, Connection jdbcConnection, ExecutionContext executionContext); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| * @param jdbcConnection The JDBC Connection. | ||
| * @param executionContext Access to contextual information useful while executing. | ||
| */ | ||
| void performPreAction(StatementAccess jdbcStatementAccess, Connection jdbcConnection, ExecutionContext executionContext); |
Check notice
Code scanning / CodeQL
Useless parameter Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHH-19782 - Oracle support for locking across joins
NOTE: Builds on top of #10752
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19602
https://hibernate.atlassian.net/browse/HHH-19782