Skip to content

Conversation

@Clopma
Copy link

@Clopma Clopma commented Apr 21, 2020

Added test with this expected faliure in order to track it and fix it at some point.

Edit: Now the expected faliure is the custom exception.

@Clopma Clopma changed the title HHH-12997 Added test to track faliure HHH-12997 Added test to keep track of @JoinFormula with @OneToMany incompatibility Apr 21, 2020
@Clopma
Copy link
Author

Clopma commented Apr 22, 2020

Updated the commit to match @NathanQingyangXu's suggestion.

@NathanQingyangXu
Copy link
Contributor

Updated the commit to match @NathanQingyangXu's suggestion.

I still don't think you correctly understand the usage. It is sort of customized foreign key. In your testing case, I failed to see the point to use it. There is no customization necessity here. It is simply a common parent child relationship. If you studied the user guide link I provided above, you would gain a better understanding of its usage.

@Clopma
Copy link
Author

Clopma commented Apr 22, 2020

Updated the commit to match @NathanQingyangXu's suggestion.

I still don't think you correctly understand the usage. It is sort of customized foreign key. In your testing case, I failed to see the point to use it. There is no customization necessity here. It is simply a common parent child relationship. If you studied the user guide link I provided above, you would gain a better understanding of its usage.

This is a simplified case, but let's say I want to make a more complex JOIN than just a SELECT * FROM child; In those cases I would need the @JoinFormula.

@NathanQingyangXu
Copy link
Contributor

Updated the commit to match @NathanQingyangXu's suggestion.

I still don't think you correctly understand the usage. It is sort of customized foreign key. In your testing case, I failed to see the point to use it. There is no customization necessity here. It is simply a common parent child relationship. If you studied the user guide link I provided above, you would gain a better understanding of its usage.

This is a simplified case, but let's say I want to make a more complex JOIN than just a SELECT * FROM child; In those cases I would need the @JoinFormula.

Yeah, but then there would not be testing failure any more.

@Clopma
Copy link
Author

Clopma commented Apr 22, 2020

Yeah, but then there would not be testing failure any more.

I don't get what are you saying. This faliure occurs whatever you put in the custom @JoinFormula. It doesn't matter if it is a simple SELECT or a complex one.

@Clopma Clopma changed the title HHH-12997 Added test to keep track of @JoinFormula with @OneToMany incompatibility HHH-12997 Specific exception thrown when trying to @JoinFormula along with @OneToMany Apr 22, 2020
I don't know why but the indentation was messed up. I mannually fixed it.
@Clopma Clopma closed this Apr 28, 2020
@Clopma Clopma deleted the HHH-12997 branch April 28, 2020 17:29
@Clopma Clopma restored the HHH-12997 branch April 28, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants