suggested fix for @Fetch(JOIN) problem

[gavinking]

This breaks quite a few tests.

Main issue with it is that fetch="join" was the way to select eager fetching in .hbm.xml.

[hibernate-github-bot]

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [e69bdaf, 49619d3]

› This message was automatically generated.

[yrodiere]

@gavinking do you remember what this was about? Searching through Jira about "join" and "fetch" obviously returns hundreds of issues, so I'd appreciate a pointer :)

[gavinking]

Looking at the code I suppose it is detecting and reporting an inconsistent use of annotations. And I guess I didn’t merge it because I wanted to check with everyone before breaking existing programs which use this (wrong) combination.

[yrodiere]

I will schedule discussing this with the team

[yrodiere]

Closing this because LAZY is the default and we can't distinguish between explicit or default LAZY.
Also, LAZY is a hint and it's fine if we don't comply with it.