-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-18684 : If no @AnyDiscriminatorValue is returned, the entity name is used as the discriminator value. #9037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
hibernate-core/src/test/java/org/hibernate/type/MetaTypeResolveTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| * SPDX-License-Identifier: LGPL-2.1-or-later | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ | ||
| package org.hibernate.type; | ||
|
|
||
| import org.hibernate.testing.orm.junit.JiraKey; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| /** | ||
| * Test {@link MetaType#resolveDiscriminatorValue(String)} and {@link MetaType#resolveEntityName(String)} | ||
| * | ||
| * @author Vincent Bouthinon | ||
| */ | ||
| @JiraKey("HHH-18684") | ||
| class MetaTypeResolveTest { | ||
|
|
||
| @Test | ||
| void resolveDiscriminatorValue_must_return_the_discriminator_value_when_the_entity_name_exist() { | ||
| // Given | ||
| Map<Object, String> discriminatorValuesToEntityNameMap = new HashMap<>(); | ||
| discriminatorValuesToEntityNameMap.put( "dog", Dog.class.getCanonicalName() ); | ||
| MetaType metaType = new MetaType( discriminatorValuesToEntityNameMap, null ); | ||
| // When | ||
| Object discriminatorValue = metaType.resolveDiscriminatorValue( Dog.class.getCanonicalName() ); | ||
| // Then | ||
| assertThat( discriminatorValue ).isEqualTo( "dog" ); | ||
| } | ||
|
|
||
| @Test | ||
| void resolveDiscriminatorValue_must_return_the_entity_name_when_the_entity_name_dont_exist() { | ||
| // Given | ||
| Map<Object, String> discriminatorValuesToEntityNameMap = new HashMap<>(); | ||
| discriminatorValuesToEntityNameMap.put( "anotherClass", MetaTypeResolveTest.class.getCanonicalName() ); | ||
| MetaType metaType = new MetaType( discriminatorValuesToEntityNameMap, null ); | ||
| // When | ||
| Object discriminatorValue = metaType.resolveDiscriminatorValue( Dog.class.getCanonicalName() ); | ||
| // Then | ||
| assertThat( discriminatorValue ).isEqualTo( Dog.class.getCanonicalName() ); | ||
| } | ||
|
|
||
| @Test | ||
| void resolveEntityName_must_return_the_entity_name_when_the_discriminator_value_exist() { | ||
| // Given | ||
| Map<Object, String> discriminatorValuesToEntityNameMap = new HashMap<>(); | ||
| discriminatorValuesToEntityNameMap.put( "dog", Dog.class.getCanonicalName() ); | ||
| MetaType metaType = new MetaType( discriminatorValuesToEntityNameMap, null ); | ||
| // When | ||
| Object resolveEntityName = metaType.resolveEntityName( "dog" ); | ||
| // Then | ||
| assertThat( resolveEntityName ).isEqualTo( Dog.class.getCanonicalName() ); | ||
| } | ||
|
|
||
| @Test | ||
| void resolveEntityName_must_return_discriminator_value_when_the_entity_name_dont_exist() { | ||
| // Given | ||
| Map<Object, String> discriminatorValuesToEntityNameMap = new HashMap<>(); | ||
| MetaType metaType = new MetaType( discriminatorValuesToEntityNameMap, null ); | ||
| // When | ||
| Object resolveEntityName = metaType.resolveEntityName( Dog.class.getCanonicalName() ); | ||
| // Then | ||
| assertThat( resolveEntityName ).isEqualTo( Dog.class.getCanonicalName() ); | ||
| } | ||
|
|
||
| private static class Dog { | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the final back to match the rest of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, as we discussed on Zulip, I think this shoud pass in the persister rather than "just" the name. That would open up the possibility for the other things we discussed (short name, etc).