HHH-18669 - Fix NPE

[jrenaat]

Resolve the driver name from the connection metadata, in case it wasn't explicitly set and access to the database metadata is allowed

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

https://hibernate.atlassian.net/browse/HHH-18669

[beikov]

I would rather not muddy the dialect with that information since this is only needed for logging purposes.
You can easily determine the driver name within a connection provider by acquiring a connection, asking for DatabaseMetaData on that connection and then releasing that connection again.

[jrenaat]

I would rather not muddy the dialect with that information since this is only needed for logging purposes. You can easily determine the driver name within a connection provider by acquiring a connection, asking for DatabaseMetaData on that connection and then releasing that connection again.

Yeah, I considered that as well, though do we really want to acquire another connection, and go get the same metedata info, when in this case we've already done it before? This is why i tried to find a way to pass that info in another way, even if not 'ideal' (which is why i also marked it as @internal) ?

[beikov]

The connection acquisition is "cheap" since it is a pooled connection, so it's fine IMO. Also, this is a startup only thing.

[beikov]

LGTM