HHH-18724 Take constraint composition type into account when determining nullable state of a Column #9092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
requested changes
Oct 15, 2024
Member
gavinking
left a comment
gavinking
left a comment
There was a problem hiding this comment.
The pull request should target main.
Also see my comments.
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
gavinking
reviewed
Oct 15, 2024
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Oct 15, 2024
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Found an edge case that needs fixing, will mark as draft for now. |
Contributor
Author
|
Fixed edge case. Added a few more tests to ensure better test coverage. |
gavinking
reviewed
Oct 23, 2024
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
gavinking
requested changes
Oct 23, 2024
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
Member
|
Thanks, looking good now. |
beikov
reviewed
Jan 20, 2025
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Outdated
Show resolved
Hide resolved
beikov
reviewed
Jan 20, 2025
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Show resolved
Hide resolved
beikov
reviewed
Jan 20, 2025
hibernate-core/src/main/java/org/hibernate/boot/beanvalidation/TypeSafeActivator.java
Show resolved
Hide resolved
…ing nullable state of a Column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18724