AbstractSqmParameter.allowMultiValuedBinding() returning true for non collection/array

[cigaly]

Only added simple query to existing test class org.hibernate.processor.test.data.multivaluebinding.TopicPostTest

from Post p where p.name = lower(:name)

Parameter is properly handled in PostRepository_, but not in Ṗost_`. Former can be expected since there method parameter type are retrieved from method signature.

Two things are wrong - lesser evil is that parameter type has not been recognized as String, but this will still create usable method. Much bigger problem is that due to fact that allow multi value binding returns false parameter type is List.

Tested with SqmNamedParameter, very likely that same problem is with SqmPositionalParameter as well.

Possible source of problem may be org.hibernate.query.hql.internal.SemanticQueryBuilder#visitFinalFunctionArgument, but I may be very wrong.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.

---

[hibernate-github-bot]

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [f543833]

› This message was automatically generated.

[gavinking]

Yeah, OK, so this really is a thing where HQL itself is too permissive. Believe it or not, it's actually a feature (or, rather, misfeature) that we tolerate varargs in function calls. And it's unfortunate that HQL doesn't currently infer the type of a parameter when it's used as an argument to a function.

[But those are nothing both issues with HQL itself, it's not Hibernate Processor at fault here.]

[cigaly]

It seems that in this case complete HHH-18960 should be reverted, it has been made with wrong assumptions :-(