Skip to content

Commit 024d998

Browse files
blafondDavideD
authored andcommitted
[#1334] replaced custom testcontainers for MariaDB & MySQL with class paths to jdbc drivers
1 parent 6ca898a commit 024d998

File tree

5 files changed

+13
-223
lines changed

5 files changed

+13
-223
lines changed

hibernate-reactive-core/build.gradle

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,13 @@ dependencies {
4646

4747
// JDBC driver for Testcontainers with MS SQL Server
4848
testRuntimeOnly "com.microsoft.sqlserver:mssql-jdbc:10.2.1.jre11"
49+
50+
// JDBC driver for Testcontainers with MariaDB Server
51+
testRuntimeOnly "org.mariadb.jdbc:mariadb-java-client:3.0.5";
52+
53+
// JDBC driver for Testcontainers with MYSQL Server
54+
testRuntimeOnly "mysql:mysql-connector-java:8.0.28";
55+
4956
// EHCache
5057
testRuntimeOnly "org.ehcache:ehcache:3.10.0"
5158
testRuntimeOnly ("org.hibernate:hibernate-jcache:${hibernateOrmVersion}") {

hibernate-reactive-core/src/test/java/org/hibernate/reactive/containers/MariaDatabase.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88

99
import static org.hibernate.reactive.containers.DockerImage.imageName;
1010

11+
import org.testcontainers.containers.MariaDBContainer;
12+
1113
class MariaDatabase extends MySQLDatabase {
1214

1315
static MariaDatabase INSTANCE = new MariaDatabase();
@@ -19,7 +21,7 @@ class MariaDatabase extends MySQLDatabase {
1921
* TIP: To reuse the same containers across multiple runs, set `testcontainers.reuse.enable=true` in a file located
2022
* at `$HOME/.testcontainers.properties` (create the file if it does not exist).
2123
*/
22-
public static final VertxMariaContainer maria = new VertxMariaContainer( imageName( "mariadb", "10.7.3" ) )
24+
public static final MariaDBContainer<?> maria = new MariaDBContainer<>( imageName( "mariadb", "10.7.3" ) )
2325
.withUsername( DatabaseConfiguration.USERNAME )
2426
.withPassword( DatabaseConfiguration.PASSWORD )
2527
.withDatabaseName( DatabaseConfiguration.DB_NAME )

hibernate-reactive-core/src/test/java/org/hibernate/reactive/containers/MySQLDatabase.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030

3131
import static org.hibernate.reactive.containers.DockerImage.imageName;
3232

33+
import org.testcontainers.containers.MySQLContainer;
34+
3335
class MySQLDatabase implements TestableDatabase {
3436

3537
static MySQLDatabase INSTANCE = new MySQLDatabase();
@@ -80,7 +82,7 @@ class MySQLDatabase implements TestableDatabase {
8082
* TIP: To reuse the same containers across multiple runs, set `testcontainers.reuse.enable=true` in a file located
8183
* at `$HOME/.testcontainers.properties` (create the file if it does not exist).
8284
*/
83-
public static final VertxMySqlContainer mysql = new VertxMySqlContainer( imageName( "mysql", "8.0.28") )
85+
public static final MySQLContainer<?> mysql = new MySQLContainer<>( imageName( "mysql", "8.0.28") )
8486
.withUsername( DatabaseConfiguration.USERNAME )
8587
.withPassword( DatabaseConfiguration.PASSWORD )
8688
.withDatabaseName( DatabaseConfiguration.DB_NAME )

hibernate-reactive-core/src/test/java/org/hibernate/reactive/containers/VertxMariaContainer.java

Lines changed: 0 additions & 110 deletions
This file was deleted.

hibernate-reactive-core/src/test/java/org/hibernate/reactive/containers/VertxMySqlContainer.java

Lines changed: 0 additions & 111 deletions
This file was deleted.

0 commit comments

Comments
 (0)