Disable tests for data types not currently supported

xml and json

Author: DavideD

hibernate-reactive-core/src/test/java/org/hibernate/reactive/schema/ColumnTypesMappingTest.java

@@ -13,6 +13,7 @@
 import java.sql.SQLException;
 import java.sql.Time;
 import java.sql.Timestamp;
+import java.time.Instant;
 import java.time.LocalDate;
 import java.time.LocalDateTime;
 import java.util.Collection;
@@ -22,6 +23,7 @@
 
 
 import org.hibernate.reactive.BaseReactiveTest;
+import org.hibernate.reactive.annotations.DisabledFor;
 import org.hibernate.type.NumericBooleanConverter;
 import org.hibernate.type.TrueFalseConverter;
 import org.hibernate.type.YesNoConverter;
@@ -34,14 +36,17 @@
 
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
+import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.SQLSERVER;
 import static org.hibernate.reactive.containers.DatabaseConfiguration.expectedDatatype;
 import static org.hibernate.reactive.containers.DatabaseConfiguration.getDatatypeQuery;
 
 /**
  * Check that each property is mapped as the expected type in the database.
  */
 @Timeout(value = 10, timeUnit = MINUTES)
-
+@DisabledFor(value = SQLSERVER, reason = "TODO: XML data type not supported")
+@DisabledFor(value = DB2, reason = "TODO: Missing support for XML data type")
 public class ColumnTypesMappingTest extends BaseReactiveTest {
 
 	@Override
@@ -215,4 +220,10 @@ public void testLocalDateTimeType(VertxTestContext context) {
 	public void testSerializableType(VertxTestContext context) {
 		testDatatype( context, "serializable", Serializable.class );
 	}
+
+	@Test
+	public void testInstantType(VertxTestContext context) {
+		testDatatype( context, "instant", Instant.class );
+	}
+
 }

hibernate-reactive-core/src/test/java/org/hibernate/reactive/schema/SchemaUpdateTestBase.java

@@ -32,6 +32,7 @@
  * when columns are missing.
  */
 @DisabledFor(value = DB2, reason = "No InformationExtractor for Dialect [org.hibernate.dialect.DB2Dialect..]")
+@DisabledFor(value = SQLSERVER, reason = "TODO: Missing support for XML data type")
 public abstract class SchemaUpdateTestBase extends BaseReactiveTest {
 
 	@Timeout(value = 10, timeUnit = MINUTES)

hibernate-reactive-core/src/test/java/org/hibernate/reactive/schema/SchemaValidationTestBase.java

@@ -25,11 +25,11 @@
 import jakarta.persistence.Table;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
+import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.MARIA;
 import static org.hibernate.tool.schema.JdbcMetadaAccessStrategy.GROUPED;
 import static org.hibernate.tool.schema.JdbcMetadaAccessStrategy.INDIVIDUALLY;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 
 /**
  * Test schema validation at startup for all the supported types:
@@ -39,6 +39,7 @@
  * - TODO: Wrong column type
  */
 @DisabledFor(value = DB2, reason = "We don't have an information extractor. See https://github.com/hibernate/hibernate-reactive/issues/911")
+@DisabledFor(value = MARIA, reason = "TODO: There are some issues with the JSON type")
 public abstract class SchemaValidationTestBase extends BaseReactiveTest {
 
 	public static class IndividuallyStrategyTest extends SchemaValidationTestBase {
@@ -104,7 +105,6 @@ public void testValidationSucceeds(VertxTestContext context) {
 		test( context, setupSessionFactory( validateConf ) );
 	}
 
-
 	// Validation should fail if a table is missing
 	@Test
 	@Timeout(value = 10, timeUnit = MINUTES)
@@ -117,9 +117,9 @@ public void testValidationFails(VertxTestContext context) {
 		final String errorMessage = "Schema-validation: missing table [" + Extra.TABLE_NAME + "]";
 		test( context, setupSessionFactory( validateConf )
 				.handle( (unused, throwable) -> {
-					assertNotNull( throwable );
-					assertEquals( throwable.getClass(), SchemaManagementException.class );
-					assertEquals( throwable.getMessage(), errorMessage );
+					assertThat( throwable ).isNotNull();
+					assertThat( throwable.getClass() ).isEqualTo( SchemaManagementException.class );
+					assertThat( throwable.getMessage() ).isEqualTo( errorMessage );
 					return null;
 				} )
 		);

hibernate-reactive-core/src/test/java/org/hibernate/reactive/types/JavaTypesArrayTest.java

@@ -40,7 +40,11 @@
 import static java.lang.Boolean.TRUE;
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
+import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.MARIA;
+import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.MYSQL;
 import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.ORACLE;
+import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.SQLSERVER;
 import static org.hibernate.reactive.containers.DatabaseConfiguration.dbType;
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
 import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -55,6 +59,10 @@
  */
 @Timeout(value = 10, timeUnit = MINUTES)
 @DisabledFor(value = ORACLE, reason = "Vert.x does not support arrays for Oracle")
+@DisabledFor(value = MYSQL, reason = "TODO: I need to create a new type for JSON arrays: See MySQLCastingJsonArrayJdbcTypeConstructor")
+@DisabledFor(value = MARIA, reason = "TODO: Same as MySQL")
+@DisabledFor(value = SQLSERVER, reason = "TODO: Missing support for XML data type")
+@DisabledFor(value = DB2, reason = "TODO: Missing support for XML data type")
 public class JavaTypesArrayTest extends BaseReactiveTest {
 
 	private static SqlStatementTracker sqlTracker;