Re-enable all Db2 test that were causing IllegalStateException

Author: DavideD

hibernate-reactive-core/src/test/java/org/hibernate/reactive/FilterWithPaginationTest.java

@@ -5,17 +5,11 @@
  */
 package org.hibernate.reactive;
 
-import java.util.Collection;
-import java.util.List;
-import java.util.Objects;
-import java.util.concurrent.CompletionStage;
-
 import org.hibernate.annotations.Filter;
 import org.hibernate.annotations.FilterDef;
 import org.hibernate.annotations.ParamDef;
 import org.hibernate.reactive.mutiny.Mutiny;
 import org.hibernate.reactive.stage.Stage;
-import org.hibernate.reactive.annotations.DisabledFor;
 import org.hibernate.type.descriptor.java.StringJavaType;
 
 import org.junit.jupiter.api.BeforeEach;
@@ -29,18 +23,20 @@
 import jakarta.persistence.Enumerated;
 import jakarta.persistence.Id;
 import jakarta.persistence.NamedQuery;
+import java.util.Collection;
+import java.util.List;
+import java.util.Objects;
+import java.util.concurrent.CompletionStage;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.hibernate.query.Page.first;
 import static org.hibernate.query.Page.page;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 
 /**
  * Test the combination of filters, max results, first result, and {@link org.hibernate.query.Page}.
  */
 @Timeout(value = 10, timeUnit = MINUTES)
-@DisabledFor(value = DB2, reason = "IllegalStateException: Needed to have 6 in buffer but only had 0")
 public class FilterWithPaginationTest extends BaseReactiveTest {
 
 	FamousPerson margaret = new FamousPerson( 1L, "Margaret Howe Lovatt", Status.LIVING, "the woman who lived in a half-flooded home with a dolphin." );

hibernate-reactive-core/src/test/java/org/hibernate/reactive/HQLQueryParameterNamedLimitTest.java

@@ -5,12 +5,6 @@
  */
 package org.hibernate.reactive;
 
-import java.util.Collection;
-import java.util.List;
-import java.util.Objects;
-
-import org.hibernate.reactive.annotations.DisabledFor;
-
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
@@ -19,18 +13,19 @@
 import jakarta.persistence.Entity;
 import jakarta.persistence.Id;
 import jakarta.persistence.Table;
+import java.util.Collection;
+import java.util.List;
+import java.util.Objects;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 /**
  * Tests queries using named parameters like ":name",
  * as defined by the JPA specification, along with limit parameters
  */
 @Timeout(value = 10, timeUnit = MINUTES)
-@DisabledFor(value = DB2, reason = "java.lang.IllegalStateException: Needed to have 6 in buffer but only had 0")
 public class HQLQueryParameterNamedLimitTest extends BaseReactiveTest {
 
 	Flour spelt = new Flour( 1, "Spelt", "An ancient grain, is a hexaploid species of wheat.", "Wheat flour" );

hibernate-reactive-core/src/test/java/org/hibernate/reactive/HQLQueryParameterPositionalLimitTest.java

@@ -5,12 +5,6 @@
  */
 package org.hibernate.reactive;
 
-import java.util.Collection;
-import java.util.List;
-import java.util.Objects;
-
-import org.hibernate.reactive.annotations.DisabledFor;
-
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
@@ -19,10 +13,12 @@
 import jakarta.persistence.Entity;
 import jakarta.persistence.Id;
 import jakarta.persistence.Table;
+import java.util.Collection;
+import java.util.List;
+import java.util.Objects;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 /**
@@ -76,7 +72,6 @@ public void testFirstResultNoResults(VertxTestContext context) {
 	}
 
 	@Test
-	@DisabledFor(value = DB2, reason = "Exception: IllegalStateException: Needed to have 6 in buffer but only had 0")
 	public void testFirstResultSingleResult(VertxTestContext context) {
 		test( context, openSession()
 				.thenCompose( s -> s
@@ -90,7 +85,6 @@ public void testFirstResultSingleResult(VertxTestContext context) {
 	}
 
 	@Test
-	@DisabledFor(value = DB2, reason = "Exception: IllegalStateException: Needed to have 6 in buffer but only had 0")
 	public void testFirstResultMultipleResults(VertxTestContext context) {
 		test( context, openSession()
 				.thenCompose( s -> s
@@ -103,7 +97,6 @@ public void testFirstResultMultipleResults(VertxTestContext context) {
 	}
 
 	@Test
-	@DisabledFor(value = DB2, reason = "Exception: IllegalStateException: Needed to have 6 in buffer but only had 0")
 	public void testFirstResultMaxResultsSingleResult(VertxTestContext context) {
 		test( context, openSession()
 				.thenCompose( s -> s

hibernate-reactive-core/src/test/java/org/hibernate/reactive/IdentifierGenerationTypeTest.java

@@ -5,13 +5,6 @@
  */
 package org.hibernate.reactive;
 
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.List;
-import java.util.Objects;
-
-import org.hibernate.reactive.annotations.DisabledFor;
-
 import org.junit.jupiter.api.Test;
 
 import io.vertx.junit5.Timeout;
@@ -20,10 +13,13 @@
 import jakarta.persistence.Entity;
 import jakarta.persistence.GeneratedValue;
 import jakarta.persistence.Id;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.List;
+import java.util.Objects;
 import org.assertj.core.api.Assertions;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -34,8 +30,6 @@
  * @see org.hibernate.reactive.id.impl.IdentifierGeneration
  */
 @Timeout(value = 10, timeUnit = MINUTES)
-@DisabledFor(value = DB2, reason = "Exception: IllegalStateException: Needed to have 6 in buffer but only had 0. " +
-	"See https://github.com/eclipse-vertx/vertx-sql-client/issues/899")
 public class IdentifierGenerationTypeTest extends BaseReactiveTest {
 
 	@Override

hibernate-reactive-core/src/test/java/org/hibernate/reactive/LazyReplaceOrphanedEntityTest.java

@@ -5,14 +5,6 @@
  */
 package org.hibernate.reactive;
 
-import java.io.Serializable;
-import java.time.OffsetDateTime;
-import java.util.Collection;
-import java.util.List;
-import java.util.UUID;
-import java.util.concurrent.CompletionStage;
-
-import org.hibernate.reactive.annotations.DisabledFor;
 import org.hibernate.reactive.util.impl.CompletionStages;
 
 import org.junit.jupiter.api.BeforeEach;
@@ -33,13 +25,17 @@
 import jakarta.persistence.InheritanceType;
 import jakarta.persistence.JoinColumn;
 import jakarta.persistence.OneToOne;
+import java.io.Serializable;
+import java.time.OffsetDateTime;
+import java.util.Collection;
+import java.util.List;
+import java.util.UUID;
+import java.util.concurrent.CompletionStage;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 
 @Timeout(value = 10, timeUnit = MINUTES)
-@DisabledFor(value = DB2, reason = "Exception: IllegalStateException: Needed to have 6 in buffer but only had 0")
 public class LazyReplaceOrphanedEntityTest extends BaseReactiveTest {
 
 	private Campaign theCampaign;

hibernate-reactive-core/src/test/java/org/hibernate/reactive/MutinyExceptionsTest.java

@@ -29,7 +29,6 @@
 import static org.hibernate.reactive.testing.ReactiveAssertions.assertThrown;
 
 @Timeout(value = 10, timeUnit = MINUTES)
-
 public class MutinyExceptionsTest extends BaseReactiveTest {
 
 	@Override

hibernate-reactive-core/src/test/java/org/hibernate/reactive/ORMReactivePersistenceTest.java

@@ -5,10 +5,6 @@
  */
 package org.hibernate.reactive;
 
-import java.util.Collection;
-import java.util.List;
-import java.util.Objects;
-
 import org.hibernate.Session;
 import org.hibernate.SessionFactory;
 import org.hibernate.boot.registry.StandardServiceRegistry;
@@ -25,22 +21,22 @@
 import jakarta.persistence.Entity;
 import jakarta.persistence.Id;
 import jakarta.persistence.Table;
+import java.util.Collection;
+import java.util.List;
+import java.util.Objects;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.COCKROACHDB;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 import static org.hibernate.reactive.containers.DatabaseConfiguration.dbType;
 import static org.hibernate.reactive.provider.Settings.DIALECT;
 import static org.hibernate.reactive.provider.Settings.DRIVER;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
-@Timeout(value = 10, timeUnit = MINUTES)
-
 /**
  * This test class verifies that data can be persisted and queried on the same database
  * using both JPA/hibernate and reactive session factories.
  */
-@DisabledFor(value = DB2, reason = "Exception: IllegalStateException: Needed to have 6 in buffer but only had 0")
+@Timeout(value = 10, timeUnit = MINUTES)
 @DisabledFor(value = COCKROACHDB, reason = "We need to change the URL schema we normally use for testing")
 public class ORMReactivePersistenceTest extends BaseReactiveTest {
 

hibernate-reactive-core/src/test/java/org/hibernate/reactive/OrderQueriesTestBase.java

@@ -5,16 +5,10 @@
  */
 package org.hibernate.reactive;
 
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.List;
-import java.util.Objects;
-
 import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
 import org.hibernate.cfg.Configuration;
 import org.hibernate.reactive.provider.Settings;
 import org.hibernate.reactive.testing.SqlStatementTracker;
-import org.hibernate.reactive.annotations.DisabledFor;
 
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.Test;
@@ -25,19 +19,20 @@
 import jakarta.persistence.Entity;
 import jakarta.persistence.Id;
 import jakarta.persistence.Table;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+import java.util.Objects;
 
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 
 /**
  * Test {@code hibernate.order_updates} and {@code hibernate.order_inserts} configurations.
  *
  * @see  Settings#ORDER_INSERTS
  * @see  Settings#ORDER_UPDATES
  */
-
-@DisabledFor(value = DB2, reason = "Exception: IllegalStateException: Needed to have 6 in buffer but only had 0")
 public abstract class OrderQueriesTestBase extends BaseReactiveTest {
 
 	public static class OrderUpdatesTest extends OrderQueriesTestBase {

hibernate-reactive-core/src/test/java/org/hibernate/reactive/OrphanRemovalTest.java

@@ -5,16 +5,6 @@
  */
 package org.hibernate.reactive;
 
-import java.util.Collection;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Objects;
-import java.util.Set;
-import java.util.concurrent.CompletionStage;
-
-
-import org.hibernate.reactive.annotations.DisabledFor;
-
 import org.junit.jupiter.api.Test;
 
 import io.vertx.junit5.Timeout;
@@ -25,16 +15,20 @@
 import jakarta.persistence.ManyToOne;
 import jakarta.persistence.OneToMany;
 import jakarta.persistence.Table;
+import java.util.Collection;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.concurrent.CompletionStage;
 
 import static jakarta.persistence.CascadeType.ALL;
 import static jakarta.persistence.CascadeType.PERSIST;
 import static jakarta.persistence.CascadeType.REMOVE;
 import static java.util.concurrent.TimeUnit.MINUTES;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 
 @Timeout( value = 10, timeUnit = MINUTES)
-@DisabledFor( value = DB2, reason = "IllegalStateException: Needed to have 6 in buffer but only had 0" )
 public class OrphanRemovalTest extends BaseReactiveTest {
 
 	@Override

hibernate-reactive-core/src/test/java/org/hibernate/reactive/RowIdUpdateAndDeleteTest.java

@@ -5,14 +5,11 @@
  */
 package org.hibernate.reactive;
 
-import java.util.Collection;
-import java.util.List;
-
 import org.hibernate.annotations.RowId;
 import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
 import org.hibernate.cfg.Configuration;
-import org.hibernate.reactive.testing.SqlStatementTracker;
 import org.hibernate.reactive.annotations.DisabledFor;
+import org.hibernate.reactive.testing.SqlStatementTracker;
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -25,15 +22,15 @@
 import jakarta.persistence.MapsId;
 import jakarta.persistence.OneToOne;
 import jakarta.persistence.Table;
+import java.util.Collection;
+import java.util.List;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.DB2;
 import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.ORACLE;
 
 /**
  * Adapted from the test with the same name in Hibernate ORM: {@literal org.hibernate.orm.test.rowid.RowIdUpdateAndDeleteTest}
  */
-@DisabledFor(value = DB2, reason = "Exception: IllegalStateException: Needed to have 6 in buffer but only had 0")
 @DisabledFor(value = ORACLE, reason = "Vert.x driver doesn't support RowId type parameters")
 public class RowIdUpdateAndDeleteTest extends BaseReactiveTest {