Remove IntelliJ warnings in main

Author: DavideD

hibernate-reactive-core/src/main/java/org/hibernate/reactive/engine/impl/ForeignKeys.java

@@ -250,7 +250,6 @@ private CompletionStage<Boolean> isNullifiable(final String entityName, Object o
 	 *
 	 * @return {@code true} if the given entity is not transient (meaning it is either detached/persistent)
 	 */
-	@SuppressWarnings("SimplifiableIfStatement")
 	public static CompletionStage<Boolean> isNotTransient(String entityName, Object entity, Boolean assumed, SessionImplementor session) {
 		if ( entity instanceof HibernateProxy ) {
 			return trueFuture();
@@ -422,7 +421,7 @@ else if ( type.isAnyType() ) {
 								nonNullableTransientEntities.add( propertyName, value );
 							}
 						} );
-			};
+			}
 		}
 		else if ( type.isComponentType() ) {
 			final CompositeType actype = (CompositeType) type;

hibernate-reactive-core/src/main/java/org/hibernate/reactive/event/impl/DefaultReactiveFlushEntityEventListener.java

@@ -525,7 +525,7 @@ class DirtyCheckContextImpl implements CustomEntityDirtinessStrategy.DirtyCheckC
 					@Override
 					public void doDirtyChecking(CustomEntityDirtinessStrategy.AttributeChecker attributeChecker) {
 						found = new DirtyCheckAttributeInfoImpl( event ).visitAttributes( attributeChecker );
-						if ( found != null && found.length == 0 ) {
+						if ( found.length == 0 ) {
 							found = null;
 						}
 					}

hibernate-reactive-core/src/main/java/org/hibernate/reactive/loader/collection/impl/ReactivePaddedBatchingCollectionInitializer.java

@@ -23,7 +23,7 @@
  */
 class ReactivePaddedBatchingCollectionInitializer extends ReactiveCollectionLoader {
 
-	private QueryableCollection persister;
+	private final QueryableCollection persister;
 	private final int[] batchSizes;
 	private final ReactiveCollectionLoader[] loaders;
 

hibernate-reactive-core/src/main/java/org/hibernate/reactive/persister/entity/impl/ReactiveAbstractEntityPersister.java

@@ -761,7 +761,6 @@ default CompletionStage<?> generateValue(
 			InMemoryValueGenerationStrategy valueGenerationStrategy) {
 		final ValueGenerator<?> valueGenerator = valueGenerationStrategy.getValueGenerator();
 		if ( valueGenerator instanceof StageValueGenerator ) {
-			final StageSessionFactoryImpl stageFactory = new StageSessionFactoryImpl( (SessionFactoryImpl) session.getFactory() );
 			final Stage.Session stageSession = new StageSessionImpl( (ReactiveSession) session );
 			return ( (StageValueGenerator<?>) valueGenerator )
 					.generateValue( stageSession, owner );

hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/SQLServerParameters.java

@@ -81,7 +81,7 @@ private static class Parser {
         private boolean inCComment;
         private boolean escaped;
         private int count = 0;
-        private StringBuilder result;
+        private final StringBuilder result;
         private int previous;
 
         private Parser(String sql) {

hibernate-reactive-core/src/main/java/org/hibernate/reactive/pool/impl/SqlClientConnection.java

@@ -150,10 +150,10 @@ private <T> T convertException(T rows, String sql, Throwable sqlException) {
 		if ( sqlException == null ) {
 			return rows;
 		}
-		if ( SQLIntegrityConstraintViolationException.class.isInstance( sqlException ) ) {
+		if ( sqlException instanceof SQLIntegrityConstraintViolationException ) {
 			throw new ConstraintViolationException( "could not execute statement", (SQLException) sqlException, sql );
 		}
-		if ( SQLException.class.isInstance( sqlException ) ) {
+		if ( sqlException instanceof SQLException ) {
 			throw new VertxSqlClientException( "could not execute statement", (SQLException) sqlException, sql );
 		}
 		return rethrow( sqlException );

hibernate-reactive-core/src/main/java/org/hibernate/reactive/provider/service/MySqlReactiveInformationExtractorImpl.java

@@ -177,11 +177,9 @@ protected <T> T processImportedKeysResultSet(
 		}
 		orderByList.add( "ordinal_position" );
 
-		if ( orderByList.size() > 0 ) {
-			sb.append( " order by " ).append( orderByList.get( 0 ) );
-			for ( int i = 1 ; i < orderByList.size() ; i++ ) {
-				sb.append( ", " ).append( orderByList.get( i ) );
-			}
+		sb.append( " order by " ).append( orderByList.get( 0 ) );
+		for ( int i = 1 ; i < orderByList.size() ; i++ ) {
+			sb.append( ", " ).append( orderByList.get( i ) );
 		}
 
 		return getExtractionContext().getQueryResults( sb.toString(), parameters.toArray(), processor );

hibernate-reactive-core/src/main/java/org/hibernate/reactive/provider/service/OracleSqlReactiveInformationExtractorImpl.java

@@ -34,7 +34,7 @@ protected <T> T processPrimaryKeysResultSet(
 			String catalogFilter,
 			String schemaFilter,
 			Identifier tableName,
-			ExtractionContext.ResultSetProcessor<T> processor) throws SQLException {
+			ExtractionContext.ResultSetProcessor<T> processor) {
 		// This functionality is not used by ORM.
 		throw new NotYetImplementedException();
 	}
@@ -79,36 +79,18 @@ protected <T> T processImportedKeysResultSet(
 				"(SELECT R_CONSTRAINT_NAME FROM USER_CONSTRAINTS WHERE OWNER = '" + schema + "' and table_name = '" + table + "' and CONSTRAINT_TYPE = 'R')";
 
 		final StringBuilder sb = new StringBuilder()
-				.append( "select " + fkNameSubquery + " as " ).append( getResultSetForeignKeyLabel() )
+				.append( "select " ).append( fkNameSubquery ).append( " as " ).append( getResultSetForeignKeyLabel() )
 				.append( ", null as " ).append( getResultSetPrimaryKeyCatalogLabel() )
 				.append( ", uc.owner as " ).append( getResultSetPrimaryKeySchemaLabel() )
 				.append( ", ucc.table_name as " ).append( getResultSetPrimaryKeyTableLabel() )
 				.append( ", ucc.column_name as ").append( getResultSetPrimaryKeyColumnNameLabel() )
 				.append( ", ucc.column_name as " ).append( getResultSetForeignKeyColumnNameLabel() )
 				.append( " from user_constraints uc join user_cons_columns ucc on uc.constraint_name = ucc.constraint_name ")
 				// Exclude primary keys, which do not have a referenced table.
-				.append( " where uc.constraint_name = " + constraintSubquery );
-
-
-		// Now add constraints for the requested catalog/schema/table
-
-		final List<Object> parameters = new ArrayList<>();
-
-		final List<String> orderByList = new ArrayList<>();
-		orderByList.add( "uc.owner" );
-		orderByList.add( "ucc.table_name" );
-		orderByList.add( "ucc.position" );
-
-		if ( orderByList.size() > 0 ) {
-			sb.append( " order by " ).append( orderByList.get( 0 ) );
-			for ( int i = 1 ; i < orderByList.size() ; i++ ) {
-				sb.append( ", " ).append( orderByList.get( i ) );
-			}
-		}
-
-		T result =  getExtractionContext().getQueryResults( sb.toString(), parameters.toArray(), processor );
+				.append( " where uc.constraint_name = " ).append( constraintSubquery )
+				.append( " order by uc.owner, ucc.table_name, ucc.position" );
 
-		return result;
+		return getExtractionContext().getQueryResults( sb.toString(), null, processor );
 	}
 
 	@Override

hibernate-reactive-core/src/main/java/org/hibernate/reactive/provider/service/SqlServerReactiveInformationExtractorImpl.java

@@ -189,12 +189,8 @@ protected <T> T processIndexInfoResultSet(
 
 		sb.append( " order by OBJECT_SCHEMA_NAME( i.object_id), OBJECT_NAME( i.object_id ), ic.key_ordinal" );
 
-		T result = getExtractionContext().getQueryResults(
-				sb.toString(),
-				parameterValues.toArray(),
-				processor
-		);
-		return result;
+		return getExtractionContext()
+				.getQueryResults( sb.toString(), parameterValues.toArray(), processor );
 	}
 
 	@Override
@@ -241,11 +237,9 @@ protected <T> T processImportedKeysResultSet(
 		}
 		orderByList.add( "constraint_column_id" );
 
-		if ( orderByList.size() > 0 ) {
-			sb.append( " order by " ).append( orderByList.get( 0 ) );
-			for ( int i = 1 ; i < orderByList.size() ; i++ ) {
-				sb.append( ", " ).append( orderByList.get( i ) );
-			}
+		sb.append( " order by " ).append( orderByList.get( 0 ) );
+		for ( int i = 1 ; i < orderByList.size() ; i++ ) {
+			sb.append( ", " ).append( orderByList.get( i ) );
 		}
 
 		return getExtractionContext().getQueryResults( sb.toString(), parameters.toArray(), processor );

hibernate-reactive-core/src/main/java/org/hibernate/reactive/session/impl/ReactiveStatelessSessionImpl.java

@@ -828,10 +828,9 @@ public <T> RootGraphImplementor<T> createEntityGraph(Class<T> entity) {
 	private RootGraphImplementor<?> createEntityGraph(String graphName) {
 		checkOpen();
 		final RootGraphImplementor<?> named = getFactory().findEntityGraphByName( graphName );
-		if ( named != null ) {
-			return named.makeRootGraph( graphName, true );
-		}
-		return named;
+		return named != null
+				? named.makeRootGraph( graphName, true )
+				: null;
 	}
 
 	private RootGraphImplementor<?> getEntityGraph(String graphName) {