Skip to content

Commit 679680f

Browse files
committed
[#1168] Re-enable Oracle tests
They were disabled because before Vert.x 4.3.1 insert-select queries weren't working.
1 parent a671245 commit 679680f

File tree

3 files changed

+0
-23
lines changed

3 files changed

+0
-23
lines changed

hibernate-reactive-core/src/test/java/org/hibernate/reactive/HQLUpdateQueryTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,16 @@
1212
import javax.persistence.Id;
1313
import javax.persistence.Table;
1414

15-
import org.hibernate.reactive.testing.DatabaseSelectionRule;
1615

1716
import org.junit.Before;
18-
import org.junit.Rule;
1917
import org.junit.Test;
2018

2119
import io.vertx.ext.unit.TestContext;
2220

23-
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.ORACLE;
2421

2522

2623
public class HQLUpdateQueryTest extends BaseReactiveTest {
2724

28-
@Rule // We cannot read a generated id in Oracle (testInsertQuery will fail)
29-
public DatabaseSelectionRule dbRule = DatabaseSelectionRule.skipTestsFor( ORACLE );
30-
3125
Flour spelt = new Flour( 1, "Spelt", "An ancient grain, is a hexaploid species of wheat.", "Wheat flour" );
3226
Flour rye = new Flour( 2, "Rye", "Used to bake the traditional sourdough breads of Germany.", "Wheat flour" );
3327
Flour almond = new Flour( 3, "Almond", "made from ground almonds.", "Gluten free" );

hibernate-reactive-core/src/test/java/org/hibernate/reactive/JoinedSubclassInheritanceTest.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,21 +21,12 @@
2121
import javax.persistence.Temporal;
2222
import javax.persistence.TemporalType;
2323

24-
import org.hibernate.reactive.testing.DatabaseSelectionRule;
25-
26-
import org.junit.Rule;
2724
import org.junit.Test;
2825

2926
import io.vertx.ext.unit.TestContext;
3027

31-
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.ORACLE;
32-
3328

3429
public class JoinedSubclassInheritanceTest extends BaseReactiveTest {
35-
36-
@Rule // We cannot read a generated id in Oracle
37-
public DatabaseSelectionRule dbRule = DatabaseSelectionRule.skipTestsFor( ORACLE );
38-
3930
@Override
4031
protected Collection<Class<?>> annotatedEntities() {
4132
return List.of( Book.class, Author.class, SpellBook.class );

hibernate-reactive-core/src/test/java/org/hibernate/reactive/UnionSubclassInheritanceTest.java

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,12 @@
2121
import javax.persistence.Temporal;
2222
import javax.persistence.TemporalType;
2323

24-
import org.hibernate.reactive.testing.DatabaseSelectionRule;
25-
26-
import org.junit.Rule;
2724
import org.junit.Test;
2825

2926
import io.vertx.ext.unit.TestContext;
3027

31-
import static org.hibernate.reactive.containers.DatabaseConfiguration.DBType.ORACLE;
32-
3328
public class UnionSubclassInheritanceTest extends BaseReactiveTest {
3429

35-
@Rule // We cannot read a generated id in Oracle
36-
public DatabaseSelectionRule dbRule = DatabaseSelectionRule.skipTestsFor( ORACLE );
37-
3830
@Override
3931
protected Collection<Class<?>> annotatedEntities() {
4032
return List.of( Book.class, Author.class, SpellBook.class );

0 commit comments

Comments
 (0)