[#2209] fix more unnecessary casts to ReactiveSession

at least some of these are not actually bugs, but some others look sus

Author: gavinking

hibernate-reactive-core/src/main/java/org/hibernate/reactive/event/impl/DefaultReactiveDeleteEventListener.java

@@ -47,6 +47,7 @@
 import org.hibernate.reactive.event.ReactiveDeleteEventListener;
 import org.hibernate.reactive.logging.impl.Log;
 import org.hibernate.reactive.logging.impl.LoggerFactory;
+import org.hibernate.reactive.session.ReactiveQueryProducer;
 import org.hibernate.reactive.session.ReactiveSession;
 import org.hibernate.type.CollectionType;
 import org.hibernate.type.CompositeType;
@@ -198,7 +199,7 @@ private CompletionStage<Void> fetchAndDelete(DeleteEvent event, DeleteContext tr
 		}
 
 		//Object entity = persistenceContext.unproxyAndReassociate( event.getObject() );
-		return ( (ReactiveSession) source )
+		return ( (ReactiveQueryProducer) source )
 				.reactiveFetch( objectEvent, true )
 				.thenCompose( entity -> delete( event, transientEntities, entity ) );
 

hibernate-reactive-core/src/main/java/org/hibernate/reactive/event/impl/DefaultReactiveLockEventListener.java

@@ -33,6 +33,7 @@
 import org.hibernate.reactive.event.ReactiveLockEventListener;
 import org.hibernate.reactive.logging.impl.Log;
 import org.hibernate.reactive.persister.entity.impl.ReactiveEntityPersister;
+import org.hibernate.reactive.session.ReactiveQueryProducer;
 import org.hibernate.reactive.session.ReactiveSession;
 
 import static java.lang.invoke.MethodHandles.lookup;
@@ -80,7 +81,7 @@ public CompletionStage<Void> reactiveOnLock(LockEvent event) throws HibernateExc
 		//TODO: if object was an uninitialized proxy, this is inefficient,
 		//      resulting in two SQL selects
 
-		return ( (ReactiveSession) source ).reactiveFetch( event.getObject(), true )
+		return ( (ReactiveQueryProducer) source ).reactiveFetch( event.getObject(), true )
 				.thenCompose( entity -> reactiveOnLock( event, entity ) );
 	}
 

hibernate-reactive-core/src/main/java/org/hibernate/reactive/event/impl/DefaultReactiveRefreshEventListener.java

@@ -37,7 +37,7 @@
 import org.hibernate.reactive.logging.impl.Log;
 import org.hibernate.reactive.logging.impl.LoggerFactory;
 import org.hibernate.reactive.persister.entity.impl.ReactiveAbstractEntityPersister;
-import org.hibernate.reactive.session.ReactiveSession;
+import org.hibernate.reactive.session.ReactiveQueryProducer;
 import org.hibernate.type.CollectionType;
 import org.hibernate.type.CompositeType;
 import org.hibernate.type.Type;
@@ -84,7 +84,7 @@ public CompletionStage<Void> reactiveOnRefresh(RefreshEvent event, RefreshContex
 			// Hibernate Reactive doesn't support detached instances in refresh()
 			throw new IllegalArgumentException( "Unmanaged instance passed to refresh()" );
 		}
-		return ( (ReactiveSession) source )
+		return ( (ReactiveQueryProducer) source )
 				.reactiveFetch( event.getObject(), true )
 				.thenCompose( entity -> reactiveOnRefresh( event, refreshedAlready, entity ) );
 	}

hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/sqm/mutation/internal/cte/ReactiveAbstractCteMutationHandler.java

@@ -30,8 +30,8 @@
 import org.hibernate.query.sqm.spi.SqmParameterMappingModelResolutionAccess;
 import org.hibernate.query.sqm.tree.SqmDeleteOrUpdateStatement;
 import org.hibernate.query.sqm.tree.expression.SqmParameter;
+import org.hibernate.reactive.engine.spi.ReactiveSharedSessionContractImplementor;
 import org.hibernate.reactive.query.sqm.mutation.spi.ReactiveAbstractMutationHandler;
-import org.hibernate.reactive.session.ReactiveSession;
 import org.hibernate.reactive.sql.exec.internal.StandardReactiveSelectExecutor;
 import org.hibernate.reactive.sql.results.spi.ReactiveListResultsConsumer;
 import org.hibernate.sql.ast.SqlAstTranslator;
@@ -176,7 +176,7 @@ public <T> MappingModelExpressible<T> getResolvedMappingModelType(SqmParameter<T
 		);
 		lockOptions.setAliasSpecificLockMode( explicitDmlTargetAlias, lockMode );
 
-		return ( (ReactiveSession) executionContext.getSession() )
+		return ( (ReactiveSharedSessionContractImplementor) executionContext.getSession() )
 				.reactiveAutoFlushIfRequired( select.getAffectedTableNames() )
 				.thenCompose( v -> StandardReactiveSelectExecutor.INSTANCE.list(
 											  select,

hibernate-reactive-core/src/main/java/org/hibernate/reactive/query/sqm/mutation/internal/cte/ReactiveCteInsertHandler.java

@@ -41,10 +41,10 @@
 import org.hibernate.query.sqm.tree.insert.SqmInsertStatement;
 import org.hibernate.query.sqm.tree.insert.SqmInsertValuesStatement;
 import org.hibernate.query.sqm.tree.insert.SqmValues;
+import org.hibernate.reactive.engine.spi.ReactiveSharedSessionContractImplementor;
 import org.hibernate.reactive.logging.impl.Log;
 import org.hibernate.reactive.logging.impl.LoggerFactory;
 import org.hibernate.reactive.query.sqm.mutation.internal.ReactiveHandler;
-import org.hibernate.reactive.session.ReactiveSession;
 import org.hibernate.reactive.sql.exec.internal.StandardReactiveSelectExecutor;
 import org.hibernate.reactive.sql.results.spi.ReactiveListResultsConsumer;
 import org.hibernate.spi.NavigablePath;
@@ -554,7 +554,7 @@ public <T> MappingModelExpressible<T> getResolvedMappingModelType(SqmParameter<T
 				executionContext.getSession()
 		);
 		final JdbcOperationQuerySelect select = translator.translate( jdbcParameterBindings, executionContext.getQueryOptions() );
-		return ( (ReactiveSession) executionContext.getSession() )
+		return ( (ReactiveSharedSessionContractImplementor) executionContext.getSession() )
 				.reactiveAutoFlushIfRequired( select.getAffectedTableNames() )
 				.thenCompose( v -> StandardReactiveSelectExecutor.INSTANCE.list(
 								select,

hibernate-reactive-core/src/main/java/org/hibernate/reactive/sql/results/graph/entity/internal/ReactiveEntityInitializerImpl.java

@@ -24,7 +24,7 @@
 import org.hibernate.persister.entity.EntityPersister;
 import org.hibernate.proxy.LazyInitializer;
 import org.hibernate.proxy.map.MapProxy;
-import org.hibernate.reactive.session.ReactiveSession;
+import org.hibernate.reactive.session.ReactiveQueryProducer;
 import org.hibernate.reactive.sql.exec.spi.ReactiveRowProcessingState;
 import org.hibernate.reactive.sql.results.graph.ReactiveInitializer;
 import org.hibernate.sql.results.graph.AssemblerCreationState;
@@ -532,7 +532,7 @@ protected CompletionStage<Object> reactiveResolveEntityInstance(ReactiveEntityIn
 				// If this initializer owns the entity, we have to remove the entity holder,
 				// because the subsequent loading process will claim the entity
 				session.getPersistenceContextInternal().removeEntityHolder( data.getEntityKey() );
-				return ( (ReactiveSession) session ).reactiveInternalLoad(
+				return ( (ReactiveQueryProducer) session ).reactiveInternalLoad(
 						data.getConcreteDescriptor().getEntityName(),
 						data.getEntityKey().getIdentifier(),
 						true,