Skip to content

Commit 158508a

Browse files
committed
HBX-2599: Change return value of 'DatabaseReaderWrapper#collectDatabaseTables()' to 'Map<String, List<TableWrapper>>'
Signed-off-by: Koen Aers <[email protected]>
1 parent 3606e81 commit 158508a

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

jbt/src/main/java/org/hibernate/tool/orm/jbt/wrp/DatabaseReaderWrapperFactory.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public static DatabaseReaderWrapper createDatabaseReaderWrapper(
3030
}
3131

3232
static interface DatabaseReaderWrapper extends Wrapper {
33-
Map<String, List<Table>> collectDatabaseTables();
33+
Map<String, List<TableWrapper>> collectDatabaseTables();
3434
}
3535

3636
static class DatabaseReaderWrapperImpl implements DatabaseReaderWrapper {
@@ -62,9 +62,9 @@ public DatabaseReaderWrapperImpl(
6262
revengMetadataCollector = new RevengMetadataCollector(metadataBuildingContext);
6363
}
6464

65-
public Map<String, List<Table>> collectDatabaseTables() {
65+
public Map<String, List<TableWrapper>> collectDatabaseTables() {
6666
databaseReader.readDatabaseSchema(revengMetadataCollector);
67-
Map<String, List<Table>> result = new HashMap<String, List<Table>>();
67+
Map<String, List<TableWrapper>> result = new HashMap<String, List<TableWrapper>>();
6868
for (Table table : revengMetadataCollector.getTables()) {
6969
String qualifier = "";
7070
if (table.getCatalog() != null) {
@@ -76,12 +76,12 @@ public Map<String, List<Table>> collectDatabaseTables() {
7676
}
7777
qualifier += table.getSchema();
7878
}
79-
List<Table> list = result.get(qualifier);
79+
List<TableWrapper> list = result.get(qualifier);
8080
if (list == null) {
81-
list = new ArrayList<Table>();
81+
list = new ArrayList<TableWrapper>();
8282
result.put(qualifier, list);
8383
}
84-
list.add(table);
84+
list.add(new DelegatingTableWrapperImpl(table));
8585
}
8686
return result;
8787
}

jbt/src/test/java/org/hibernate/tool/orm/jbt/wrp/DatabaseReaderWrapperFactoryTest.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,18 @@ public void testCollectDatabaseTables() throws Exception {
4646
Connection connection = DriverManager.getConnection("jdbc:h2:mem:test");
4747
Statement statement = connection.createStatement();
4848
statement.execute("CREATE TABLE FOO(id int primary key, bar varchar(255))");
49-
Map<String, List<Table>> tableMap = databaseReaderWrapper.collectDatabaseTables();
50-
assertEquals(2, tableMap.size());
51-
Set<String> tableMapKeys = tableMap.keySet();
49+
Map<String, List<TableWrapper>> tableWrapperMap = databaseReaderWrapper.collectDatabaseTables();
50+
assertEquals(2, tableWrapperMap.size());
51+
Set<String> tableMapKeys = tableWrapperMap.keySet();
5252
assertTrue(tableMapKeys.contains("TEST.PUBLIC"));
5353
assertTrue(tableMapKeys.contains("TEST.INFORMATION_SCHEMA"));
54-
List<Table> tables = tableMap.get("TEST.PUBLIC");
55-
assertEquals(1, tables.size());
56-
Table table = tables.get(0);
57-
assertEquals("TEST", table.getCatalog());
58-
assertEquals("PUBLIC", table.getSchema());
59-
assertEquals("FOO", table.getName());
54+
List<TableWrapper> tableWrappers = tableWrapperMap.get("TEST.PUBLIC");
55+
assertEquals(1, tableWrappers.size());
56+
TableWrapper tableWrapper = tableWrappers.get(0);
57+
assertEquals("TEST", tableWrapper.getCatalog());
58+
assertEquals("PUBLIC", tableWrapper.getSchema());
59+
assertEquals("FOO", tableWrapper.getName());
60+
assertTrue(tableWrapper.getColumnIterator().hasNext());
6061
statement.execute("DROP TABLE FOO");
6162
statement.close();
6263
connection.close();

0 commit comments

Comments
 (0)