Skip to content

Commit 6c0777c

Browse files
committed
HBX-3080: Refactor the Gradle integration tests to factor out common code
- Make test class 'GenerateJavaTest' extend 'TestTemplate' - Rename the test method to 'testPackageName' and adapt it to the new template Signed-off-by: Koen Aers <[email protected]>
1 parent 2f3bea0 commit 6c0777c

File tree

1 file changed

+23
-31
lines changed

1 file changed

+23
-31
lines changed

gradle/plugin/src/functionalTest/java/org/hibernate/tool/gradle/GenerateJavaTest.java

Lines changed: 23 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -21,43 +21,35 @@
2121

2222
import java.io.File;
2323
import java.io.IOException;
24+
import java.nio.file.Files;
2425

2526
import org.gradle.testkit.runner.BuildResult;
2627
import org.hibernate.tool.gradle.test.func.utils.FuncTestConstants;
2728
import org.hibernate.tool.gradle.test.func.utils.FuncTestTemplate;
29+
import org.hibernate.tool.it.gradle.TestTemplate;
2830
import org.junit.jupiter.api.Test;
2931

30-
class GenerateJavaTest extends FuncTestTemplate implements FuncTestConstants {
32+
class GenerateJavaTest extends TestTemplate {
3133

32-
private static final String BUILD_FILE_HIBERNATE_TOOLS_SECTION =
33-
"hibernateTools {\n" +
34-
" packageName = 'foo.model'\n" +
35-
"}\n";
36-
37-
@Override
38-
public String getBuildFileHibernateToolsSection() {
39-
return BUILD_FILE_HIBERNATE_TOOLS_SECTION;
34+
@Test
35+
public void testPackageName() throws Exception {
36+
setDatabaseCreationScript(new String[] {
37+
"create table PERSON (ID int not null, NAME varchar(20), primary key (ID))"
38+
});
39+
setHibernateToolsExtensionSection(
40+
"hibernateTools { \n" +
41+
" packageName = 'foo.model' \n" +
42+
"}"
43+
);
44+
createProject();
45+
executeGradleCommand("generateJava");
46+
File generatedSourcesFolder = new File(getProjectDir(), "app/generated-sources");
47+
assertTrue(generatedSourcesFolder.exists());
48+
assertTrue(generatedSourcesFolder.isDirectory());
49+
File fooFile = new File(generatedSourcesFolder, "foo/model/Person.java");
50+
assertTrue(fooFile.exists());
51+
assertTrue(fooFile.isFile());
4052
}
4153

42-
@Test
43-
void testGenerateJava() throws IOException {
44-
performTask("generateJava", true);
45-
}
46-
47-
@Override
48-
protected void verifyBuild(BuildResult buildResult) {
49-
try {
50-
File generatedSourcesFolder = new File(projectDir, "generated-sources");
51-
assertTrue(buildResult.getOutput().contains(
52-
"Starting Java export to directory: " + generatedSourcesFolder.getCanonicalPath()));
53-
assertTrue(generatedSourcesFolder.exists());
54-
assertTrue(generatedSourcesFolder.isDirectory());
55-
File fooFile = new File(generatedSourcesFolder, "foo/model/Foo.java");
56-
assertTrue(fooFile.exists());
57-
assertTrue(fooFile.isFile());
58-
} catch (Exception e) {
59-
throw new RuntimeException(e);
60-
}
61-
}
62-
63-
}
54+
55+
}

0 commit comments

Comments
 (0)