HBX-3128: Avoid use of Maven invoker plugin while performing functional testing

  - Reorganize test class ExamplesTestIT

Signed-off-by: Koen Aers <[email protected]>

Author: koentsje

maven/src/functionalTest/java/org/hibernate/tool/maven/ExamplesTestIT.java

@@ -5,6 +5,7 @@
 import static org.junit.jupiter.api.Assertions.fail;
 
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import org.apache.maven.cli.MavenCli;
@@ -21,6 +22,14 @@ public class ExamplesTestIT {
     private static File baseFolder;
     private static File localRepo;
 
+    private File projectFolder;
+    private MavenCli mavenCli;
+
+    private String[] databaseCreationScript = new String[] {
+            // This is the default database which can be overridden per test
+            "create table PERSON (ID int not null, NAME varchar(20), primary key (ID))"
+    };
+
     @BeforeAll
     public static void beforeAll() throws Exception {
         // The needed resource for this test are put in place
@@ -29,32 +38,26 @@ public static void beforeAll() throws Exception {
         // See the 'pom.xml'
         baseFolder = determineBaseFolder();
         localRepo = new File(baseFolder.getParentFile(), "local-repo");
-        createDatabase();
     }
 
-    private MavenCli mavenCli;
+    @BeforeEach
+    public void beforeEach() throws Exception {
+        createDatabase();
+    }
 
     @Test
     public void test5MinuteTutorial() throws Exception {
-        File projectFolder = prepareProjectFolder("5-minute-tutorial");
-        File generatedPersonFile = new File(projectFolder, "target/generated-sources/Person.java");
-        assertFalse(generatedPersonFile.exists());
-        new MavenCli().doMain(
-                new String[]{"-Dmaven.repo.local=" + localRepo.getAbsolutePath(), "generate-sources"},
-                projectFolder.getAbsolutePath(),
-                null,
-                null);
-        assertTrue(generatedPersonFile.exists());
-        String personFileContents = new String(Files.readAllBytes(generatedPersonFile.toPath()));
-        assertTrue(personFileContents.contains("public class Person"));
+        prepareProject("5-minute-tutorial");
+        assertNotGeneratedYet();
+        runGenerateSources();
+        assertGeneratedContains("public class Person");
     }
 
-    private File prepareProjectFolder(String projectName) throws Exception {
-        File projectFolder = new File(baseFolder, projectName);
+    private void prepareProject(String projectName) throws Exception {
+        projectFolder = new File(baseFolder, projectName);
         assertTrue(projectFolder.exists());
         System.setProperty(MVN_HOME, projectFolder.getAbsolutePath());
         createHibernatePropertiesFile(projectFolder);
-        return projectFolder;
     }
 
     private void createHibernatePropertiesFile(File projectFolder) throws Exception {
@@ -73,18 +76,46 @@ private void createHibernatePropertiesFile(File projectFolder) throws Exception
         assertTrue(hibernatePropertiesFile.exists());
     }
 
+    private void runGenerateSources() {
+        new MavenCli().doMain(
+                new String[]{"-Dmaven.repo.local=" + localRepo.getAbsolutePath(), "generate-sources"},
+                projectFolder.getAbsolutePath(),
+                null,
+                null);
+    }
+
+    private void assertNotGeneratedYet() {
+        assertFalse(new File(projectFolder, "target/generated-sources/Person.java").exists());
+    }
+
+    private void assertGeneratedContains(String contents) throws Exception {
+        assertTrue(readGeneratedContents().contains(contents));
+    }
+
+    private void assertGeneratedDoesNotContain(String contents) throws Exception {
+        assertFalse(readGeneratedContents().contains(contents));
+    }
+
+    private String readGeneratedContents() throws Exception {
+        File generatedPersonFile = new File(projectFolder, "target/generated-sources/Person.java");
+        assertTrue(generatedPersonFile.exists());
+        return new String(Files.readAllBytes(generatedPersonFile.toPath()));
+    }
+
     private static File determineBaseFolder() throws Exception {
         return new File(ExamplesTestIT.class.getClassLoader().getResource("5-minute-tutorial/pom.xml").toURI())
                 .getParentFile().getParentFile();
     }
 
-    private static void createDatabase() throws Exception {
+    private void createDatabase() throws Exception {
         File databaseFile = new File(baseFolder, "database/test.mv.db");
         assertFalse(databaseFile.exists());
         assertFalse(databaseFile.isFile());
         Connection connection = DriverManager.getConnection(constructJdbcConnectionString());
         Statement statement = connection.createStatement();
-        statement.execute("create table PERSON (ID int not null, NAME varchar(20), primary key (ID))");
+        for (String s : databaseCreationScript) {
+            statement.execute(s);
+        }
         statement.close();
         connection.close();
         assertTrue(databaseFile.exists());