HBX-2614 - Check isNullable() in BasicPOJOClass::isRequiredInConstructor.

jimbogithub · jimbogithub · commit a4e40a5ad105 · 2023-10-16T09:39:54.000+13:00
Restores previous Minimal Constructors behavior lost when isNullable() check removed from core org.hibernate.mapping.Property.isOptional().
diff --git a/orm/src/main/java/org/hibernate/tool/internal/export/java/BasicPOJOClass.java b/orm/src/main/java/org/hibernate/tool/internal/export/java/BasicPOJOClass.java
@@ -817,7 +817,7 @@ protected boolean isRequiredInConstructor(Property field) {
 			return false;
 		}
 		if(field.getValue()!=null) {			
-			if (!field.isOptional() && (field.getValueGeneratorCreator() == null )) {				
+			if (!(field.isOptional() || field.getValue().isNullable()) && (field.getValueGeneratorCreator() == null )) {				
 				return true;
 			} else if (field.getValue() instanceof Component) {
 				Component c = (Component) field.getValue();

Original file line number	Diff line number	Diff line change
`@@ -817,7 +817,7 @@ protected boolean isRequiredInConstructor(Property field) {`
`817`	`817`	`return false;`
`818`	`818`	`}`
`819`	`819`	`if(field.getValue()!=null) {`
`820`		`- if (!field.isOptional() && (field.getValueGeneratorCreator() == null )) {`
	`820`	`+ if (!(field.isOptional() \|\| field.getValue().isNullable()) && (field.getValueGeneratorCreator() == null )) {`
`821`	`821`	`return true;`
`822`	`822`	`} else if (field.getValue() instanceof Component) {`
`823`	`823`	`Component c = (Component) field.getValue();`