HBX-3068: Refactor the Ant integration tests to factor out common code #5324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
koentsje
commented
Jul 31, 2025
koentsje
commented
- Create an abstract method 'createDatabaseScript()' to return an array of SQL statements for the database creation
- Implement this method in the integration test classes
- Modify the 'createDatabase()' method to use the above script and pull up to TestTemplate
- Pull up the methods 'constructJdbcConnectionString()' and createBuildXmlFile() to TestTemplate
- Get rid of the local variables and '@beforeeach' method for all the integration test classes
- Create an abstract method 'createDatabaseScript()' to return an array of SQL statements for the database creation - Implement this method in the integration test classes - Modify the 'createDatabase()' method to use the above script and pull up to TestTemplate - Pull up the methods 'constructJdbcConnectionString()' and createBuildXmlFile() to TestTemplate - Get rid of the local variables and '@beforeeach' method for all the integration test classes Signed-off-by: Koen Aers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.