Skip to content

HBX-3080: Refactor the Gradle integration tests to factor out common code #5408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

HBX-3080: Refactor the Gradle integration tests to factor out common code #5408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions gradle/plugin/src/functionalTest/java/org/hibernate/tool/gradle/java/JpaDefaultTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,4 @@ private void verifyProject() throws Exception {
assertTrue(generatedPersonJavaFileContents.contains("public class Person "));
}

private void addHibernateToolsPluginLine(StringBuffer gradleBuildFileContents) {
int pos = gradleBuildFileContents.indexOf("plugins {");
pos = gradleBuildFileContents.indexOf("}", pos);
gradleBuildFileContents.insert(pos, constructHibernateToolsPluginLine() + "\n");
}

}
6 changes: 0 additions & 6 deletions gradle/plugin/src/functionalTest/java/org/hibernate/tool/gradle/java/NoAnnotationsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,6 @@ private void verifyProject() throws Exception {
assertTrue(generatedPersonJavaFileContents.contains("public class Person "));
}

private void addHibernateToolsPluginLine(StringBuffer gradleBuildFileContents) {
int pos = gradleBuildFileContents.indexOf("plugins {");
pos = gradleBuildFileContents.indexOf("}", pos);
gradleBuildFileContents.insert(pos, constructHibernateToolsPluginLine() + "\n");
}

private void addHibernateToolsExtension(StringBuffer gradleBuildFileContents) {
int pos = gradleBuildFileContents.indexOf("dependencies {");
pos = gradleBuildFileContents.indexOf("}", pos);
Expand Down
6 changes: 0 additions & 6 deletions gradle/plugin/src/functionalTest/java/org/hibernate/tool/gradle/java/NoGenerics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,6 @@ private void verifyProject() throws Exception {
assertTrue(generatedItemJavaFileContents.contains("public class Item "));
}

private void addHibernateToolsPluginLine(StringBuffer gradleBuildFileContents) {
int pos = gradleBuildFileContents.indexOf("plugins {");
pos = gradleBuildFileContents.indexOf("}", pos);
gradleBuildFileContents.insert(pos, constructHibernateToolsPluginLine() + "\n");
}

private void addHibernateToolsExtension(StringBuffer gradleBuildFileContents) {
int pos = gradleBuildFileContents.indexOf("dependencies {");
pos = gradleBuildFileContents.indexOf("}", pos);
Expand Down
6 changes: 0 additions & 6 deletions gradle/plugin/src/functionalTest/java/org/hibernate/tool/gradle/java/UseGenerics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,4 @@ private void verifyProject() throws Exception {
assertTrue(generatedItemJavaFileContents.contains("public class Item "));
}

private void addHibernateToolsPluginLine(StringBuffer gradleBuildFileContents) {
int pos = gradleBuildFileContents.indexOf("plugins {");
pos = gradleBuildFileContents.indexOf("}", pos);
gradleBuildFileContents.insert(pos, constructHibernateToolsPluginLine() + "\n");
}

}
6 changes: 0 additions & 6 deletions gradle/plugin/src/functionalTest/java/org/hibernate/tool/gradle/tutorial/TutorialTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,4 @@ private void verifyProject() {
assertTrue(generatedPersonJavaFile.isFile());
}

private void addHibernateToolsPluginLine(StringBuffer gradleBuildFileContents) {
int pos = gradleBuildFileContents.indexOf("plugins {");
pos = gradleBuildFileContents.indexOf("}", pos);
gradleBuildFileContents.insert(pos, constructHibernateToolsPluginLine() + "\n");
}

}
6 changes: 6 additions & 0 deletions gradle/plugin/src/functionalTest/java/org/hibernate/tool/it/gradle/TestTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,10 @@ protected void addH2DatabaseDependencyLine(StringBuffer gradleBuildFileContents)
gradleBuildFileContents.insert(pos, constructH2DatabaseDependencyLine() + "\n");
}

protected void addHibernateToolsPluginLine(StringBuffer gradleBuildFileContents) {
int pos = gradleBuildFileContents.indexOf("plugins {");
pos = gradleBuildFileContents.indexOf("}", pos);
gradleBuildFileContents.insert(pos, constructHibernateToolsPluginLine() + "\n");
}

}