From b9df14e2fb7b8ac822212567e2b424aa3501ba5c Mon Sep 17 00:00:00 2001
From: Koen Aers <koen.aers@gmail.com>
Date: Fri, 19 Sep 2025 11:28:43 +0200
Subject: [PATCH] HBX-3050: Add a functional tests for the Maven generateJava
 mojo  guarding the sanity of the 5 minute tutorial   - Change the used
 property '@project.version@' into @hibernate.version@ and add the property to
 'maven/pom.xml'   - Change the delimiters for the filtering of the
 'h2.version' and 'hibernate.version' properties in
 '5-minute-tutorial/pom.xml'   - Add a 'README.md' to the '5-minute-tutorial'
 example, describing how to run it

Signed-off-by: Koen Aers <koen.aers@gmail.com>
---
 .../docs/examples/5-minute-tutorial/README.md | 22 +++++++++++++++++++
 maven/docs/examples/5-minute-tutorial/pom.xml |  4 ++--
 maven/pom.xml                                 |  8 +++++--
 3 files changed, 30 insertions(+), 4 deletions(-)
 create mode 100644 maven/docs/examples/5-minute-tutorial/README.md

diff --git a/maven/docs/examples/5-minute-tutorial/README.md b/maven/docs/examples/5-minute-tutorial/README.md
new file mode 100644
index 000000000..52dce31ac
--- /dev/null
+++ b/maven/docs/examples/5-minute-tutorial/README.md
@@ -0,0 +1,22 @@
+<!--
+  ~ Copyright 2004 - 2025 Red Hat, Inc.
+  ~
+  ~ Licensed under the Apache License, Version 2.0 (the "License");
+  ~ you may not use this file except in compliance with the License.
+  ~ You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" basis,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+To run this example:
+  - Have [Apache Maven](https://maven.apache.org) installed
+  - Have [H2 Sakila database](https://github.com/hibernate/sakila-h2) running
+  - Issue one of the following commands from a command-line window opened in this folder:
+    - `mvn generate-sources -Dh2.version=${h2.version} -Dproject.version=${hibernate.version}`
+    - `mvn hbm2java -Dh2.version=${h2.version} -Dproject.version=${hibernate.version}` 
+  
\ No newline at end of file
diff --git a/maven/docs/examples/5-minute-tutorial/pom.xml b/maven/docs/examples/5-minute-tutorial/pom.xml
index a8038c870..155065d44 100644
--- a/maven/docs/examples/5-minute-tutorial/pom.xml
+++ b/maven/docs/examples/5-minute-tutorial/pom.xml
@@ -27,7 +27,7 @@
         <dependency>
             <groupId>com.h2database</groupId>
             <artifactId>h2</artifactId>
-            <version>@h2.version@</version>
+            <version>${h2.version}</version>
         </dependency>
     </dependencies>
 
@@ -36,7 +36,7 @@
             <plugin>
                 <groupId>org.hibernate.tool</groupId>
                 <artifactId>hibernate-tools-maven</artifactId>
-                <version>@project.version@</version>
+                <version>${hibernate.version}</version>
                 <executions>
                     <execution>
                         <id>Entity generation</id>
diff --git a/maven/pom.xml b/maven/pom.xml
index dc779be0f..7a70741db 100644
--- a/maven/pom.xml
+++ b/maven/pom.xml
@@ -34,6 +34,8 @@
     <!-- This is a publicly distributed module that should be published: -->
     <deploy.skip>false</deploy.skip>
     <maven.install.skip>false</maven.install.skip>
+    <!-- To run the integration tests we need to set ${hibernate.version} -->
+    <hibernate.version>${project.version}</hibernate.version>
   </properties>
 
   <dependencies>
@@ -153,6 +155,8 @@
           </execution>
         </executions>
       </plugin>
+      <!-- The Invoker plugin will populate the local Maven repository with the artefacts
+           needed to run the integration tests with the FailSafe plugin -->
       <plugin>
         <artifactId>maven-invoker-plugin</artifactId>
         <version>${maven-invoker-plugin.version}</version>
@@ -181,7 +185,7 @@
           </execution>
         </executions>
       </plugin>
-      <!-- run the integration tests -->
+      <!-- Run the integration tests -->
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-failsafe-plugin</artifactId>
@@ -252,7 +256,7 @@
                 </resource>
               </resources>
               <delimiters>
-                <delimiter>@*@</delimiter>
+                <delimiter>${*}</delimiter>
               </delimiters>
             </configuration>
           </execution>