Skip to content

Commit 096c6ee

Browse files
gsmetgunnarmorling
authored andcommitted
HV-1478 Fix the Fragment-Host header to reference the correct bundle
name Note: in 6.1, we will make the Java 9 module names and the bundle names identical but it seemed like a bad idea to do that in a micro.
1 parent b2c6987 commit 096c6ee

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

cdi/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
<properties>
2424
<hibernate-validator-parent.path>..</hibernate-validator-parent.path>
25-
<automatic.module.name>org.hibernate.validator.cdi</automatic.module.name>
2625
</properties>
2726

2827
<dependencies>
@@ -155,7 +154,7 @@
155154
<manifestEntries>
156155
<Specification-Title>Bean Validation</Specification-Title>
157156
<Specification-Version>2.0</Specification-Version>
158-
<Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
157+
<Automatic-Module-Name>${hibernate-validator-cdi.module-name}</Automatic-Module-Name>
159158
</manifestEntries>
160159
</archive>
161160
</configuration>
@@ -167,7 +166,8 @@
167166
<artifactId>maven-bundle-plugin</artifactId>
168167
<configuration>
169168
<instructions>
170-
<Fragment-Host>org.hibernate.validator</Fragment-Host>
169+
<Bundle-SymbolicName>${hibernate-validator-cdi.bundle-name}</Bundle-SymbolicName>
170+
<Fragment-Host>${hibernate-validator.bundle-name}</Fragment-Host>
171171
<Import-Package>
172172
org.hibernate.validator.*;version="[${project.version},${project.version}]",
173173
javax.annotation.*;version="[1.2,2.0)",

engine/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
<properties>
2424
<hibernate-validator-parent.path>..</hibernate-validator-parent.path>
25-
<automatic.module.name>org.hibernate.validator</automatic.module.name>
2625
</properties>
2726

2827
<distributionManagement>
@@ -200,7 +199,7 @@
200199
<manifestEntries>
201200
<Specification-Title>Bean Validation</Specification-Title>
202201
<Specification-Version>2.0</Specification-Version>
203-
<Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
202+
<Automatic-Module-Name>${hibernate-validator.module-name}</Automatic-Module-Name>
204203
</manifestEntries>
205204
</archive>
206205
</configuration>
@@ -212,6 +211,7 @@
212211
<artifactId>maven-bundle-plugin</artifactId>
213212
<configuration>
214213
<instructions>
214+
<Bundle-SymbolicName>${hibernate-validator.bundle-name}</Bundle-SymbolicName>
215215
<Import-Package>
216216
javax.persistence.*;version="[2.0.0,3.0.0)";resolution:=optional,
217217
javax.validation.*;version="[2.0.0,3.0.0)",

pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,13 @@
9999
<maven.compiler.source>1.8</maven.compiler.source>
100100
<maven.compiler.target>1.8</maven.compiler.target>
101101

102+
<!-- Module names used for Java 9 modules and OSGi bundles -->
103+
<hibernate-validator.module-name>org.hibernate.validator</hibernate-validator.module-name>
104+
<hibernate-validator-cdi.module-name>org.hibernate.validator.cdi</hibernate-validator-cdi.module-name>
105+
<!-- TODO in 6.1: make the names consistent by removing the bundle properties, see HV-1484 -->
106+
<hibernate-validator.bundle-name>org.hibernate.validator.hibernate-validator</hibernate-validator.bundle-name>
107+
<hibernate-validator-cdi.bundle-name>org.hibernate.validator.hibernate-validator-cdi</hibernate-validator-cdi.bundle-name>
108+
102109
<!-- see http://maven.apache.org/general.html -->
103110
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
104111
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

0 commit comments

Comments
 (0)