HV-2135 Do not create unnecessary context for cascading into container elements

Signed-off-by: marko-bekhta <[email protected]>

Author: marko-bekhta

engine/src/main/java/org/hibernate/validator/internal/engine/ValidatorImpl.java

@@ -781,14 +781,13 @@ private void doValidate(Object value, String nodeName) {
 
 			// Cascade validation to container elements if we are dealing with a container element
 			if ( cascadingMetaData.hasContainerElementsMarkedForCascading() ) {
-				ValueContext<?, Object> cascadedTypeArgumentValueContext = buildNewLocalExecutionContext( valueContext, value );
 				if ( cascadingMetaData.getTypeParameter() != null ) {
 					cascadedValueContext.setTypeParameter( cascadingMetaData.getDeclaredContainerClass(), cascadingMetaData.getDeclaredTypeParameterIndex() );
 				}
 
-				cascadedTypeArgumentValueContext.appendTypeParameterNode( nodeName );
+				cascadedValueContext.appendTypeParameterNode( nodeName );
 
-				validateCascadedContainerElementsInContext( value, validationContext, cascadedTypeArgumentValueContext, cascadingMetaData, validationOrder );
+				validateCascadedContainerElementsInContext( value, validationContext, cascadedValueContext, cascadingMetaData, validationOrder );
 			}
 		}
 	}

engine/src/main/java/org/hibernate/validator/internal/engine/path/MutablePath.java

@@ -172,8 +172,6 @@ public void setLeafNodeValueIfRequired(Object value) {
 		// The value is only exposed for property and container element nodes
 		if ( currentLeafNode.getKind() == ElementKind.PROPERTY || currentLeafNode.getKind() == ElementKind.CONTAINER_ELEMENT ) {
 			currentLeafNode.setPropertyValue( value );
-
-			// the property value is not part of the NodeImpl hashCode so we don't need to reset the PathImpl hashCode
 		}
 	}