HV-1701 Add a couple more test cases

- for number test add more number types to cover the logic of
`compare(Number...)` and all ifs in it
- For DecimalM?? constraints added a case with decimal fraction in
constraint value. "integer" values should be already covered.

Author: marko-bekhta

engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/BaseMinMaxValidatorForNumberTest.java

@@ -13,6 +13,7 @@
 import java.lang.annotation.Annotation;
 import java.math.BigDecimal;
 import java.math.BigInteger;
+
 import javax.validation.ConstraintValidator;
 
 /**
@@ -39,6 +40,18 @@ protected <A extends Annotation> void testNumberValidator(ConstraintValidator<A,
 		assertEquals( constraint.isValid( b, null ), isMax );
 		assertEquals( constraint.isValid( 14.99, null ), isMax );
 		assertEquals( constraint.isValid( -14.99, null ), isMax );
+		assertEquals( constraint.isValid( 14.99F, null ), isMax );
+		assertEquals( constraint.isValid( -14.99F, null ), isMax );
+		assertEquals( constraint.isValid( 14, null ), isMax );
+		assertEquals( constraint.isValid( 16, null ), !isMax );
+		assertEquals( constraint.isValid( (short) 14, null ), isMax );
+		assertEquals( constraint.isValid( (short) 16, null ), !isMax );
+		assertEquals( constraint.isValid( BigInteger.valueOf( 14L ), null ), isMax );
+		assertEquals( constraint.isValid( BigInteger.valueOf( 16L ), null ), !isMax );
+		assertEquals( constraint.isValid( BigDecimal.valueOf( 14L ), null ), isMax );
+		assertEquals( constraint.isValid( BigDecimal.valueOf( 16L ), null ), !isMax );
+		assertEquals( constraint.isValid( new BigDecimal( "14.99" ), null ), isMax );
+		assertEquals( constraint.isValid( new BigDecimal( "15.001" ), null ), !isMax );
 		assertEquals( constraint.isValid( bWrapper, null ), !isMax );
 		assertEquals( constraint.isValid( 20, null ), !isMax );
 	}

engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MaxValidatorForNumberTest.java

@@ -6,11 +6,16 @@
  */
 package org.hibernate.validator.test.internal.constraintvalidators.bv;
 
+import static org.hibernate.validator.testutil.ConstraintViolationAssert.assertNoViolations;
+import static org.hibernate.validator.testutil.ConstraintViolationAssert.assertThat;
+import static org.hibernate.validator.testutil.ConstraintViolationAssert.violationOf;
+import static org.hibernate.validator.testutils.ValidatorUtil.getValidator;
 import static org.testng.Assert.assertFalse;
 
 import java.math.BigDecimal;
 import java.math.BigInteger;
 
+import javax.validation.Validator;
 import javax.validation.constraints.DecimalMax;
 import javax.validation.constraints.Max;
 
@@ -36,6 +41,7 @@
 import org.hibernate.validator.internal.constraintvalidators.bv.number.bound.decimal.DecimalMaxValidatorForShort;
 import org.hibernate.validator.internal.util.annotation.ConstraintAnnotationDescriptor;
 import org.hibernate.validator.testutil.TestForIssue;
+
 import org.testng.annotations.Test;
 
 /**
@@ -66,6 +72,29 @@ public void testIsValidDecimalMax() {
 		testDecimalMax( m, true );
 	}
 
+	@Test
+	public void testIsValidDecimalMaxWithDecimalFractionInConstraint() {
+		class Foo {
+			@DecimalMax("15.0001")
+			private final Number num;
+
+			Foo(final Number num) {
+				this.num = num;
+			}
+		}
+
+		Validator validator = getValidator();
+
+		assertThat( validator.validate( new Foo( 16 ) ) ).containsOnlyViolations( violationOf( DecimalMax.class ) );
+		assertNoViolations( validator.validate( new Foo( 15 ) ) );
+
+		assertThat( validator.validate( new Foo( 15.01 ) ) ).containsOnlyViolations( violationOf( DecimalMax.class ) );
+		assertNoViolations( validator.validate( new Foo( 15.00001 ) ) );
+
+		assertThat( validator.validate( new Foo( BigDecimal.valueOf( 15.01 ) ) ) ).containsOnlyViolations( violationOf( DecimalMax.class ) );
+		assertNoViolations( validator.validate( new Foo( BigDecimal.valueOf( 15.00001 ) ) ) );
+	}
+
 	@Test
 	public void testIsValidDecimalMax1() {
 		ConstraintAnnotationDescriptor.Builder<DecimalMax> descriptorBuilder = new ConstraintAnnotationDescriptor.Builder<>( DecimalMax.class );

engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/bv/MinValidatorForNumberTest.java

@@ -6,6 +6,14 @@
  */
 package org.hibernate.validator.test.internal.constraintvalidators.bv;
 
+import static org.hibernate.validator.testutil.ConstraintViolationAssert.assertNoViolations;
+import static org.hibernate.validator.testutil.ConstraintViolationAssert.assertThat;
+import static org.hibernate.validator.testutil.ConstraintViolationAssert.violationOf;
+import static org.hibernate.validator.testutils.ValidatorUtil.getValidator;
+
+import java.math.BigDecimal;
+
+import javax.validation.Validator;
 import javax.validation.constraints.DecimalMin;
 import javax.validation.constraints.Min;
 
@@ -31,6 +39,7 @@
 import org.hibernate.validator.internal.constraintvalidators.bv.number.bound.decimal.DecimalMinValidatorForShort;
 import org.hibernate.validator.internal.util.annotation.ConstraintAnnotationDescriptor;
 import org.hibernate.validator.testutil.TestForIssue;
+
 import org.testng.annotations.Test;
 
 /**
@@ -61,6 +70,29 @@ public void testIsValidDecimalMinValidator() {
 		testDecimalMin( m, true );
 	}
 
+	@Test
+	public void testIsValidDecimalMinWithDecimalFractionInConstraint() {
+		class Foo {
+			@DecimalMin("15.0001")
+			private final Number num;
+
+			Foo(final Number num) {
+				this.num = num;
+			}
+		}
+
+		Validator validator = getValidator();
+
+		assertThat( validator.validate( new Foo( 15 ) ) ).containsOnlyViolations( violationOf( DecimalMin.class ) );
+		assertNoViolations( validator.validate( new Foo( 16 ) ) );
+
+		assertThat( validator.validate( new Foo( 15.00001 ) ) ).containsOnlyViolations( violationOf( DecimalMin.class ) );
+		assertNoViolations( validator.validate( new Foo( 15.01 ) ) );
+
+		assertThat( validator.validate( new Foo( BigDecimal.valueOf( 15.00001 ) ) ) ).containsOnlyViolations( violationOf( DecimalMin.class ) );
+		assertNoViolations( validator.validate( new Foo( BigDecimal.valueOf( 15.01 ) ) ) );
+	}
+
 	@Test(expectedExceptions = IllegalArgumentException.class)
 	public void testInitializeDecimalMinWithInvalidValue() {
 		ConstraintAnnotationDescriptor.Builder<DecimalMin> descriptorBuilder = new ConstraintAnnotationDescriptor.Builder<>( DecimalMin.class );