HV-1591 Log a warning for improper use of Valid annotation

Signed-off-by: marko-bekhta <[email protected]>

Author: DavideD

engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/CascadingMetaDataBuilder.java

@@ -224,6 +224,9 @@ public CascadingMetaData build(ValueExtractorManager valueExtractorManager, Obje
 		Set<ValueExtractorDescriptor> containerDetectionValueExtractorCandidates = valueExtractorManager.getResolver()
 				.getValueExtractorCandidatesForContainerDetectionOfGlobalCascadedValidation( enclosingType );
 		if ( !containerDetectionValueExtractorCandidates.isEmpty() ) {
+			// Using @Valid on a container is deprecated at the moment. You are supposed to apply the annotation on the type argument(s).
+			LOG.deprecatedUseOfValidOnContainer( ReflectionHelper.getClassFromType( enclosingType ), context );
+
 			if ( containerDetectionValueExtractorCandidates.size() > 1 ) {
 				throw LOG.getUnableToGetMostSpecificValueExtractorDueToSeveralMaximallySpecificValueExtractorsDeclaredException(
 						ReflectionHelper.getClassFromType( enclosingType ),
@@ -259,6 +262,7 @@ public CascadingMetaData build(ValueExtractorManager valueExtractorManager, Obje
 		// and they will be used at runtime to check if any of those could be applied to a runtime type and if PotentiallyContainerCascadingMetaData
 		// should be promoted to ContainerCascadingMetaData or not.
 		if ( !potentialValueExtractorCandidates.isEmpty() ) {
+			LOG.potentiallyDeprecatedUseOfValidOnContainer( ReflectionHelper.getClassFromType( enclosingType ), context );
 			return PotentiallyContainerCascadingMetaData.of( this, potentialValueExtractorCandidates, context );
 		}
 

engine/src/main/java/org/hibernate/validator/internal/util/logging/Log.java

@@ -952,6 +952,11 @@ ConstraintDefinitionException getConstraintValidatorDefinitionConstraintMismatch
 	void resourceBundleNotPreLoaded(Locale localeToPreload);
 
 	@LogMessage(level = WARN)
-	@Message(id = 271, value = "Using `@Valid` on a container (%1$s) is deprecated. You should apply the annotation on the type argument(s). Field name: %2$s")
+	@Message(id = 271, value = "Using `@Valid` on a container (%1$s) is deprecated. You should apply the annotation on the type argument(s). Affected element: %2$s")
 	void deprecatedUseOfValidOnContainer(@FormatWith(ClassObjectFormatter.class) Class<?> valueType, Object context);
+
+	@LogMessage(level = WARN)
+	@Message(id = 272,
+			value = "Using `@Valid` on a container is deprecated. You should apply the annotation on the type argument(s). (%1$s) can potentially be a container at runtime. Affected element: %2$s")
+	void potentiallyDeprecatedUseOfValidOnContainer(@FormatWith(ClassObjectFormatter.class) Class<?> valueType, Object context);
 }