HV-1628 Be more careful about the locale we use

Author: gsmet

annotation-processor/src/main/java/org/hibernate/validator/ap/internal/util/Configuration.java

@@ -6,8 +6,9 @@
  */
 package org.hibernate.validator.ap.internal.util;
 
-import java.text.MessageFormat;
+import java.util.Locale;
 import java.util.Map;
+
 import javax.annotation.processing.Messager;
 import javax.tools.Diagnostic.Kind;
 
@@ -97,11 +98,12 @@ private Kind getDiagnosticKindOption(Map<String, String> options, Messager messa
 			}
 			catch (IllegalArgumentException e) {
 				messager.printMessage(
-						Kind.WARNING, MessageFormat.format(
-						"The given value {0} is no valid diagnostic kind. {1} will be used.",
-						diagnosticKindFromOptions,
-						DEFAULT_DIAGNOSTIC_KIND
-				)
+						Kind.WARNING, String.format(
+								Locale.ROOT,
+								"The given value %1$s is no valid diagnostic kind. %2$s will be used.",
+								diagnosticKindFromOptions,
+								DEFAULT_DIAGNOSTIC_KIND
+						)
 				);
 			}
 		}
@@ -118,10 +120,11 @@ private boolean getVerboseOption(Map<String, String> options, Messager messager)
 
 		if ( theValue ) {
 			messager.printMessage(
-					Kind.NOTE, MessageFormat.format(
-					"Verbose reporting is activated. Some processing information will be displayed using diagnostic kind {0}.",
-					Kind.NOTE
-			)
+					Kind.NOTE, String.format(
+							Locale.ROOT,
+							"Verbose reporting is activated. Some processing information will be displayed using diagnostic kind %1$s.",
+							Kind.NOTE
+					)
 			);
 		}
 

annotation-processor/src/main/java/org/hibernate/validator/ap/internal/util/MessagerAdapter.java

@@ -8,6 +8,7 @@
 
 import java.text.MessageFormat;
 import java.util.Collection;
+import java.util.Locale;
 import java.util.ResourceBundle;
 
 import javax.annotation.processing.Messager;
@@ -45,7 +46,7 @@ public MessagerAdapter(Messager messager, Kind diagnosticKind) {
 		this.messager = messager;
 		this.diagnosticKind = diagnosticKind;
 
-		errorMessages = ResourceBundle.getBundle( "org.hibernate.validator.ap.ValidationProcessorMessages" );
+		errorMessages = ResourceBundle.getBundle( "org.hibernate.validator.ap.ValidationProcessorMessages", Locale.getDefault() );
 	}
 
 	/**
@@ -114,7 +115,8 @@ private void report(ConstraintCheckIssue issue, Kind kind) {
 		String message = errorMessages.getString( issue.getMessageKey() );
 
 		if ( issue.getMessageParameters() != null ) {
-			message = MessageFormat.format( message, issue.getMessageParameters() );
+			MessageFormat messageFormat = new MessageFormat( message, Locale.getDefault() );
+			message = messageFormat.format( issue.getMessageParameters() );
 		}
 
 		messager.printMessage(

engine/src/main/java/org/hibernate/validator/internal/cfg/context/TypeConstraintMappingContextImpl.java

@@ -18,6 +18,7 @@
 import java.security.PrivilegedAction;
 import java.util.Arrays;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 
 import org.hibernate.validator.cfg.ConstraintDef;
@@ -269,7 +270,7 @@ private Member getMember(Class<?> clazz, String property, ElementType elementTyp
 			member = run( GetDeclaredField.action( clazz, property ) );
 		}
 		else {
-			String methodName = property.substring( 0, 1 ).toUpperCase() + property.substring( 1 );
+			String methodName = property.substring( 0, 1 ).toUpperCase( Locale.ROOT ) + property.substring( 1 );
 			for ( String prefix : ReflectionHelper.PROPERTY_ACCESSOR_PREFIXES ) {
 				member = run( GetMethod.action( clazz, prefix + methodName ) );
 				if ( member != null ) {

engine/src/main/java/org/hibernate/validator/internal/util/Contracts.java

@@ -10,6 +10,7 @@
 
 import java.lang.invoke.MethodHandles;
 import java.util.Collection;
+import java.util.Locale;
 
 import org.hibernate.validator.internal.util.logging.Log;
 import org.hibernate.validator.internal.util.logging.LoggerFactory;
@@ -69,7 +70,7 @@ public static void assertTrue(boolean condition, String message) {
 
 	public static void assertTrue(boolean condition, String message, Object... messageParameters) {
 		if ( !condition ) {
-			throw LOG.getIllegalArgumentException( String.format( message, messageParameters ) );
+			throw LOG.getIllegalArgumentException( String.format( Locale.ROOT, message, messageParameters ) );
 		}
 	}
 
@@ -87,7 +88,7 @@ public static void assertNotEmpty(Collection<?> collection, String message) {
 
 	public static void assertNotEmpty(Collection<?> collection, String message, Object... messageParameters) {
 		if ( collection.size() == 0 ) {
-			throw LOG.getIllegalArgumentException( String.format( message, messageParameters ) );
+			throw LOG.getIllegalArgumentException( String.format( Locale.ROOT, message, messageParameters ) );
 		}
 	}
 }

performance/src/main/java/org/hibernate/validator/performance/statistical/TestEntity.java

@@ -7,9 +7,13 @@
 package org.hibernate.validator.performance.statistical;
 
 import java.math.BigDecimal;
+import java.time.ZoneId;
 import java.util.Calendar;
 import java.util.Date;
 import java.util.GregorianCalendar;
+import java.util.Locale;
+import java.util.TimeZone;
+
 import javax.validation.Valid;
 import javax.validation.constraints.AssertFalse;
 import javax.validation.constraints.AssertTrue;
@@ -28,7 +32,7 @@
  */
 public class TestEntity {
 	public static final int MAX_DEPTH = 10;
-	private static final Calendar cal = GregorianCalendar.getInstance();
+	private static final Calendar cal = GregorianCalendar.getInstance( TimeZone.getTimeZone( ZoneId.of( "GMT" ) ), Locale.ROOT );
 
 	public TestEntity(int depth) {
 		if ( depth <= MAX_DEPTH ) {

test-utils/src/main/java/org/hibernate/validator/testutil/ConstraintViolationAssert.java

@@ -14,6 +14,7 @@
 import java.util.Arrays;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 import java.util.stream.Collectors;
 
@@ -272,7 +273,8 @@ public void containsOnlyViolations(ViolationExpectation... expectedViolations) {
 				referencePropertiesToTest = expectedViolations[0].propertiesToTest;
 				for ( ViolationExpectation expectedViolation : expectedViolations ) {
 					if ( !referencePropertiesToTest.equals( expectedViolation.propertiesToTest ) ) {
-						throw new IllegalArgumentException( String.format( "Expected violations passed in parameter must test the exact same properties but do not: %1$s != %2$s",
+						throw new IllegalArgumentException( String.format( Locale.ROOT,
+								"Expected violations passed in parameter must test the exact same properties but do not: %1$s != %2$s",
 								expectedViolations[0], expectedViolation ) );
 					}
 				}
@@ -309,7 +311,7 @@ public void containsPath(PathExpectation expectedPath) {
 				actualPaths.add( actual );
 			}
 
-			fail( String.format( "Didn't find path <%s> in actual paths <%s>.", expectedPath, actualPaths ) );
+			fail( String.format( Locale.ROOT, "Didn't find path <%s> in actual paths <%s>.", expectedPath, actualPaths ) );
 		}
 
 		public void containsPaths(PathExpectation... expectedPaths) {

test-utils/src/main/java/org/hibernate/validator/testutil/DescriptorAssert.java

@@ -8,11 +8,13 @@
 
 import static org.testng.Assert.fail;
 
-import org.assertj.core.api.IterableAssert;
-
+import java.util.Locale;
 import java.util.Set;
+
 import javax.validation.metadata.GroupConversionDescriptor;
 
+import org.assertj.core.api.IterableAssert;
+
 /**
  * Provides assertion methods for testing {@link javax.validation.metadata.ElementDescriptor}
  * implementations and collections thereof.
@@ -54,7 +56,7 @@ public void containsConversion(Class<?> from, Class<?> to) {
 			}
 
 			if ( !foundMatchingConversion ) {
-				fail( String.format( "<%s> does not contain a conversion from <%s> to <%s>.", actual, from, to ) );
+				fail( String.format( Locale.ROOT, "<%s> does not contain a conversion from <%s> to <%s>.", actual, from, to ) );
 			}
 		}
 	}