HV-2127 Make root node constant

Signed-off-by: marko-bekhta <[email protected]>

Author: marko-bekhta

engine/src/main/java/org/hibernate/validator/internal/engine/path/NodeImpl.java

@@ -43,6 +43,13 @@ public class NodeImpl
 
 	private static final Log LOG = LoggerFactory.make( MethodHandles.lookup() );
 
+	static final NodeImpl ROOT_NODE;
+	static {
+		ROOT_NODE = NodeImpl.createBeanNode( null );
+		ROOT_NODE.valueSet = true;
+		ROOT_NODE.hashCode();
+	}
+
 	private static final String INDEX_OPEN = "[";
 	private static final String INDEX_CLOSE = "]";
 	private static final String TYPE_PARAMETER_OPEN = "<";
@@ -553,7 +560,6 @@ else if ( !Arrays.equals( parameterTypes, other.parameterTypes ) ) {
 	}
 
 	boolean isRootPath() {
-		// .size() == 1 && nodeList.get( 0 ).getName() == null
 		return parent == null && name == null;
 	}
 

engine/src/main/java/org/hibernate/validator/internal/engine/path/PathImpl.java

@@ -67,7 +67,7 @@ public final class PathImpl implements Path, Serializable {
 	public static PathImpl createPathFromString(String propertyPath) {
 		Contracts.assertNotNull( propertyPath, MESSAGES.propertyPathCannotBeNull() );
 
-		if ( propertyPath.length() == 0 ) {
+		if ( propertyPath.isEmpty() ) {
 			return createRootPath();
 		}
 
@@ -90,9 +90,7 @@ public static PathImpl createPathForExecutable(ExecutableMetaData executable) {
 	}
 
 	public static PathImpl createRootPath() {
-		PathImpl path = new PathImpl();
-		path.addBeanNode();
-		return path;
+		return new PathImpl( NodeImpl.ROOT_NODE );
 	}
 
 	public static PathImpl createCopy(PathImpl path) {