Skip to content

Commit aea431b

Browse files
marko-bekhtamarko-bekhta
committed
HV-2051 Remove checkstyle rules addressed by other plugins
1 parent 0e79fc6 commit aea431b

File tree

1 file changed

+4
-88
lines changed

1 file changed

+4
-88
lines changed

‎build/build-config/src/main/resources/checkstyle.xml‎

Lines changed: 4 additions & 88 deletions
Original file line numberDiff line numberDiff line change
@@ -14,69 +14,19 @@
1414

1515
<module name="TreeWalker">
1616

17+
<!-- cannot do with spotless but then is it really needed ? -->
1718
<module name="RegexpSinglelineJava">
1819
<!-- do not allow a package declaration that contains ".target." or "target;" -->
1920
<property name="format" value="^package .*\.target[\.;]"/>
2021
<property name="message" value="Do not use &quot;target&quot; as package name element"/>
2122
</module>
2223

23-
<!-- Use tabs -->
24-
<module name="RegexpSinglelineJava">
25-
<property name="format" value="^ +\t*\S" />
26-
<property name="message" value="Line has leading space characters; indentation should be performed with tabs only." />
27-
<property name="ignoreComments" value="true" />
28-
</module>
29-
30-
<!-- Check parentheses padding -->
31-
<module name="RegexpSinglelineJava">
32-
<property name="format" value="^\t+(if|for|while|catch)([^ ])\(" />
33-
<property name="message" value="Left parentheses should be preceeded by 1 whitespace" />
34-
<property name="ignoreComments" value="true" />
35-
</module>
36-
37-
<module name="RegexpSinglelineJava">
38-
<property name="format" value="^\t+(if|for|while) \( .+[^ ]\) \{$" />
39-
<property name="message" value="Right parentheses should be preceeded by 1 white space" />
40-
<property name="ignoreComments" value="true" />
41-
</module>
42-
43-
<module name="RegexpSinglelineJava">
44-
<property name="format" value="^\t+(if|for|while) \([^ $]" />
45-
<property name="message" value="Left parentheses should be followed by 1 whitespace" />
46-
<property name="ignoreComments" value="true" />
47-
</module>
48-
49-
<module name="RegexpSinglelineJava">
50-
<property name="format" value="\)([^ ])\{$" />
51-
<property name="message" value="Right parentheses should be followed by 1 white space" />
52-
<property name="ignoreComments" value="true" />
53-
</module>
54-
55-
<module name="RegexpSinglelineJava">
56-
<property name="format" value="catch \([^\w]" />
57-
<property name="message" value="'catch' clause does not require white space after left parentheses" />
58-
<property name="ignoreComments" value="true" />
59-
</module>
60-
61-
<module name="RegexpSinglelineJava">
62-
<property name="format" value="catch \(.*\s\) \{" />
63-
<property name="message" value="'catch' clause does not require white space before right parentheses" />
64-
<property name="ignoreComments" value="true" />
65-
</module>
66-
67-
<module name="RegexpSinglelineJava">
68-
<property name="format" value="\)\s+;$" />
69-
<property name="message" value="Unecessary whitespace after parentheses" />
70-
<property name="ignoreComments" value="true" />
71-
</module>
72-
73-
<!-- Checks for imports -->
74-
<module name="AvoidStarImport"/>
75-
7624
<!-- Checks for common coding problems -->
25+
<!-- didn't find any alternatives for these two: -->
7726
<module name="EqualsHashCode" />
7827
<module name="IllegalInstantiation" />
7928

29+
<!-- didn't find any alternatives for this next group: -->
8030
<!-- Miscellaneous other checks. -->
8131
<module name="ModifierOrder" />
8232
<module name="PackageAnnotation" />
@@ -93,53 +43,19 @@
9343
<module name="EqualsAvoidNull" />
9444
<module name="UpperEll"/>
9545

46+
<!-- didn't find any alternatives for this next group: -->
9647
<!-- not checking for Constructor here: -->
9748
<module name="RedundantModifier">
9849
<property name="tokens"
9950
value="METHOD_DEF, VARIABLE_DEF, ANNOTATION_FIELD_DEF, INTERFACE_DEF, CLASS_DEF, ENUM_DEF"/>
10051
</module>
10152
<module name="MissingOverride" />
10253

103-
<module name="MethodParamPad">
104-
<property name="option" value="nospace" />
105-
<property name="allowLineBreaks" value="false" />
106-
</module>
107-
108-
<!-- Checks for blocks. You know, those {}'s, not doing this for methods because of 1 line getters/setters-->
109-
<module name="LeftCurly">
110-
<property name="option" value="eol"/>
111-
<property name="tokens" value="INTERFACE_DEF, CLASS_DEF, ANNOTATION_DEF, ENUM_DEF, CTOR_DEF,
112-
ENUM_CONSTANT_DEF, LITERAL_WHILE, LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY,
113-
LITERAL_SYNCHRONIZED, LITERAL_SWITCH, LITERAL_DO, LITERAL_IF, LITERAL_ELSE, LITERAL_FOR,
114-
STATIC_INIT, OBJBLOCK" />
115-
</module>
116-
<!-- not doing this for methods because of 1 line getters/setters -->
117-
<module name="RightCurly">
118-
<property name="option" value="alone"/>
119-
<property name="tokens" value="LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF,
120-
LITERAL_ELSE, CLASS_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE,
121-
STATIC_INIT, INSTANCE_INIT" />
122-
</module>
123-
124-
<module name="ParenPad">
125-
<property name="tokens" value="CTOR_CALL, METHOD_CALL, SUPER_CTOR_CALL, LITERAL_FOR, LITERAL_IF,
126-
LITERAL_WHILE, LITERAL_SWITCH, LITERAL_NEW, RESOURCE_SPECIFICATION"/>
127-
<property name="option" value="space"/>
128-
</module>
129-
13054
<module name="SuppressionCommentFilter" />
13155
</module>
13256

133-
<module name="RegexpSingleline">
134-
<property name="format" value="\s+$" />
135-
<property name="message" value="White spaces at the end of line" />
136-
</module>
137-
13857
<module name="SuppressionFilter">
13958
<property name="file" value="/suppressions.xml" />
14059
</module>
14160

142-
<!-- Checks that a file ends with a new line -->
143-
<module name="NewlineAtEndOfFile"/>
144-
14561
</module>

0 commit comments

Comments
 (0)