HV-1480 Avoid removing and adding element to the node list

We can directly set the element in the list. It avoids some list
resizing.

Author: gsmet

engine/src/main/java/org/hibernate/validator/internal/engine/path/PathImpl.java

@@ -178,44 +178,39 @@ private NodeImpl addMethodNode(String name, Class<?>[] parameterTypes) {
 	public NodeImpl makeLeafNodeIterable() {
 		currentLeafNode = NodeImpl.makeIterable( currentLeafNode );
 
-		nodeList.remove( nodeList.size() - 1 );
-		nodeList.add( currentLeafNode );
+		nodeList.set( nodeList.size() - 1, currentLeafNode );
 		hashCode = -1;
 		return currentLeafNode;
 	}
 
 	public NodeImpl setLeafNodeIndex(Integer index) {
 		currentLeafNode = NodeImpl.setIndex( currentLeafNode, index );
 
-		nodeList.remove( nodeList.size() - 1 );
-		nodeList.add( currentLeafNode );
+		nodeList.set( nodeList.size() - 1, currentLeafNode );
 		hashCode = -1;
 		return currentLeafNode;
 	}
 
 	public NodeImpl setLeafNodeMapKey(Object key) {
 		currentLeafNode = NodeImpl.setMapKey( currentLeafNode, key );
 
-		nodeList.remove( nodeList.size() - 1 );
-		nodeList.add( currentLeafNode );
+		nodeList.set( nodeList.size() - 1, currentLeafNode );
 		hashCode = -1;
 		return currentLeafNode;
 	}
 
 	public NodeImpl setLeafNodeValue(Object value) {
 		currentLeafNode = NodeImpl.setPropertyValue( currentLeafNode, value );
 
-		nodeList.remove( nodeList.size() - 1 );
-		nodeList.add( currentLeafNode );
+		nodeList.set( nodeList.size() - 1, currentLeafNode );
 		hashCode = -1;
 		return currentLeafNode;
 	}
 
 	public NodeImpl setLeafNodeTypeParameter(Class<?> containerClass, Integer typeArgumentIndex) {
 		currentLeafNode = NodeImpl.setTypeParameter( currentLeafNode, containerClass, typeArgumentIndex );
 
-		nodeList.remove( nodeList.size() - 1 );
-		nodeList.add( currentLeafNode );
+		nodeList.set( nodeList.size() - 1, currentLeafNode );
 		hashCode = -1;
 		return currentLeafNode;
 	}