HV-1623 Remove redundant check in ConfiguredConstraint

- based on the usage of the method we cannot receive methods into it,
hence the check can be removed. And also the method can be named more
specific to represent what it is really should be doing.

Author: marko-bekhta

engine/src/main/java/org/hibernate/validator/internal/cfg/context/ConfiguredConstraint.java

@@ -21,9 +21,7 @@
 import org.hibernate.validator.cfg.ConstraintDef;
 import org.hibernate.validator.internal.metadata.location.ConstraintLocation;
 import org.hibernate.validator.internal.properties.Callable;
-import org.hibernate.validator.internal.properties.Property;
 import org.hibernate.validator.internal.properties.javabean.JavaBeanField;
-import org.hibernate.validator.internal.properties.javabean.JavaBeanGetter;
 import org.hibernate.validator.internal.util.annotation.AnnotationDescriptor;
 import org.hibernate.validator.internal.util.annotation.ConstraintAnnotationDescriptor;
 import org.hibernate.validator.internal.util.logging.Log;
@@ -57,13 +55,11 @@ static <A extends Annotation> ConfiguredConstraint<A> forType(ConstraintDef<?, A
 		return new ConfiguredConstraint<>( constraint, ConstraintLocation.forClass( beanType ), ElementType.TYPE );
 	}
 
-	static <A extends Annotation> ConfiguredConstraint<A> forProperty(ConstraintDef<?, A> constraint, Property property) {
+	static <A extends Annotation> ConfiguredConstraint<A> forFieldProperty(ConstraintDef<?, A> constraint, JavaBeanField javaBeanField) {
 		return new ConfiguredConstraint<>(
 				constraint,
-				property instanceof JavaBeanField
-						? ConstraintLocation.forField( property.as( JavaBeanField.class ) )
-						: ConstraintLocation.forGetter( property.as( JavaBeanGetter.class ) ),
-				property instanceof JavaBeanField ? ElementType.FIELD : ElementType.METHOD
+				ConstraintLocation.forField( javaBeanField ),
+				ElementType.FIELD
 		);
 	}
 

engine/src/main/java/org/hibernate/validator/internal/cfg/context/PropertyConstraintMappingContextImpl.java

@@ -62,8 +62,8 @@ protected PropertyConstraintMappingContextImpl getThis() {
 	public PropertyConstraintMappingContext constraint(ConstraintDef<?, ?> definition) {
 		if ( property instanceof JavaBeanField ) {
 			super.addConstraint(
-					ConfiguredConstraint.forProperty(
-							definition, property
+					ConfiguredConstraint.forFieldProperty(
+							definition, property.as( JavaBeanField.class )
 					)
 			);
 		}