From 3d460064540a3efc94cca077da8e3a5dbd7b2010 Mon Sep 17 00:00:00 2001 From: jundonghyuk Date: Fri, 6 Jun 2025 14:14:49 +0900 Subject: [PATCH 1/2] HV-2113 Adding condition to validate a date --- .../internal/constraintvalidators/hv/kor/KorRRNValidator.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/hv/kor/KorRRNValidator.java b/engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/hv/kor/KorRRNValidator.java index 3ebf96b526..19ccf4bb7f 100644 --- a/engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/hv/kor/KorRRNValidator.java +++ b/engine/src/main/java/org/hibernate/validator/internal/constraintvalidators/hv/kor/KorRRNValidator.java @@ -87,7 +87,7 @@ private static boolean isValidChecksum(final String rrn) { private static boolean isValidDate(final String rrn) { final int month = extractMonth( rrn ); final int day = extractDay( rrn ); - if ( month > 12 || day < 0 || day > 31 ) { + if ( month < 1 || month > 12 || day < 1 || day > 31 ) { return false; } return day <= 31 && ( day <= 30 || ( month != 4 && month != 6 && month != 9 && month != 11 ) ) && ( day <= 29 || month != 2 ); From a99854b64ccfbec285cbe7c9e39cfa9b5ddb2b81 Mon Sep 17 00:00:00 2001 From: jundonghyuk Date: Fri, 6 Jun 2025 14:16:43 +0900 Subject: [PATCH 2/2] HV-2113 Adding test cases for date validation --- .../hv/kor/KorRRNValidatorNeverAttrTest.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/hv/kor/KorRRNValidatorNeverAttrTest.java b/engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/hv/kor/KorRRNValidatorNeverAttrTest.java index 765ac99c2d..e95e4fd43b 100644 --- a/engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/hv/kor/KorRRNValidatorNeverAttrTest.java +++ b/engine/src/test/java/org/hibernate/validator/test/internal/constraintvalidators/hv/kor/KorRRNValidatorNeverAttrTest.java @@ -70,6 +70,9 @@ void testNeverAttrWithoutHyphen() { void invalidDate() { assertInvalidRRN( "861324-2567481" ); assertInvalidRRN( "960292-2499371" ); + assertInvalidRRN( "000001-1234560" ); + assertInvalidRRN( "000100-1234560" ); + assertInvalidRRN( "000000-1234560" ); } // Invalid RRN Length