Skip to content

Commit 044fdf8

Browse files
committed
feat: changed the --key parameter to be optional for batch plugin create method
Signed-off-by: rozekmichal <michal.rozek@blockydevs.com>
1 parent 33dc43f commit 044fdf8

File tree

4 files changed

+18
-16
lines changed

4 files changed

+18
-16
lines changed

docs/adr/ADR-010-batch-transaction-plugin.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,12 @@ export class CreateBatchCommand implements Command {
101101
validArgs.keyManager ||
102102
api.config.getOption<KeyManagerName>('default_key_manager');
103103

104-
const resolved = await api.keyResolver.resolveSigningKey(
105-
validArgs.key,
106-
keyManager,
107-
['batch:signer'],
108-
);
104+
const resolved =
105+
await api.keyResolver.resolveAccountCredentialsWithFallback(
106+
validArgs.key,
107+
keyManager,
108+
['batch:signer'],
109+
);
109110

110111
batchState.saveBatch(validArgs.name, {
111112
name: validArgs.name,
@@ -117,7 +118,7 @@ export class CreateBatchCommand implements Command {
117118
}
118119
```
119120

120-
CLI usage: `hiero batch create --name my-batch --key <key>`
121+
CLI usage: `hiero batch create --name my-batch` (--key optional, defaults to operator)
121122

122123
### Part 4: Execute Command
123124

@@ -451,7 +452,7 @@ sequenceDiagram
451452
participant Network as Hedera Network
452453
participant DomainHook as TokenStateHook
453454
454-
User->>CLI: batch create --name my-batch --key <key>
455+
User->>CLI: batch create --name my-batch
455456
CLI->>CreateBatchCmd: execute(args)
456457
CreateBatchCmd->>BatchState: saveBatch("my-batch", data)
457458
CreateBatchCmd-->>User: Batch 'my-batch' created

src/plugins/batch/commands/create/handler.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@ export class CreateBatchCommand implements Command {
3131
validArgs.keyManager ||
3232
api.config.getOption<KeyManagerName>('default_key_manager');
3333

34-
const resolved = await api.keyResolver.resolveSigningKey(
35-
batchKey,
36-
keyManager,
37-
['batch:signer'],
38-
);
34+
const resolved =
35+
await api.keyResolver.resolveAccountCredentialsWithFallback(
36+
batchKey,
37+
keyManager,
38+
['batch:signer'],
39+
);
3940

4041
const batchData = {
4142
name,

src/plugins/batch/commands/create/input.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import {
1111
*/
1212
export const CreateBatchInputSchema = z.object({
1313
name: AliasNameSchema.describe('Batch name'),
14-
key: PrivateKeySchema.describe(
15-
'Key to sign transactions in the batch. Can be {accountId}:{privateKey} pair, account private key in {ed25519|ecdsa}:private:{private-key} format, key reference or account alias',
14+
key: PrivateKeySchema.optional().describe(
15+
'Key to sign transactions in the batch. Defaults to operator when omitted. Can be {accountId}:{privateKey} pair, account private key in {ed25519|ecdsa}:private:{private-key} format, key reference or account alias',
1616
),
1717
keyManager: KeyManagerTypeSchema.optional().describe(
1818
'Key manager type (defaults to config setting)',

src/plugins/batch/manifest.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,9 @@ export const batchPluginManifest: PluginManifest = {
6868
name: 'key',
6969
short: 'k',
7070
type: OptionType.STRING,
71-
required: true,
71+
required: false,
7272
description:
73-
'Key to sign transactions. Can be {accountId}:{privateKey} pair, account private key in {ed25519|ecdsa}:private:{private-key} format, key reference or account alias',
73+
'Key to sign transactions. Defaults to operator when omitted. Can be {accountId}:{privateKey} pair, account private key in {ed25519|ecdsa}:private:{private-key} format, key reference or account alias',
7474
},
7575
{
7676
name: 'key-manager',

0 commit comments

Comments
 (0)