feat(1209): nft implementation review changes (#1215)

Signed-off-by: rozekmichal <michal.rozek@blockydevs.com>

Author: rozekmichal

src/plugins/token/commands/create-nft/output.ts

@@ -38,15 +38,15 @@ export type CreateNftOutput = z.infer<typeof CreateNftOutputSchema>;
  * Human-readable template for create token output
  */
 export const CREATE_NFT_TEMPLATE = `
-✅ NFT created successfully: {{tokenId}}
+✅ NFT created successfully: {{hashscanLink tokenId "token" network}}
    Name: {{name}} ({{symbol}})
-   Treasury: {{treasuryId}}
+   Treasury: {{hashscanLink treasuryId "account" network}}
    Supply Type: {{supplyType}}
-   Admin account: {{adminAccountId}}
-   Supply account: {{supplyAccountId}}
+   Admin account: {{hashscanLink adminAccountId "account" network}}
+   Supply account: {{hashscanLink supplyAccountId "account" network}}
 {{#if alias}}
    Alias: {{alias}}
 {{/if}}
    Network: {{network}}
-   Transaction ID: {{transactionId}}
+   Transaction ID: {{hashscanLink transactionId "transaction" network}}
 `.trim();

src/plugins/token/commands/list/output.ts

@@ -108,7 +108,7 @@ export const LIST_TOKENS_TEMPLATE = `
    Supply Type: {{supplyType}}
    Decimals: {{decimals}}
    Network: {{network}}
-{{#if maxSupply}}
+{{#if (eq supplyType "FINITE")}}
    Max Supply: {{maxSupply}}
 {{/if}}
 {{#if (gt associationCount 0)}}

src/plugins/token/commands/view/handler.ts

@@ -65,7 +65,7 @@ export async function viewToken(
     }
 
     // 3. Build output based on mode
-    const output: ViewTokenOutput = buildOutput(tokenInfo, nftInfo);
+    const output: ViewTokenOutput = buildOutput(tokenInfo, nftInfo, network);
 
     return {
       status: Status.Success,

src/plugins/token/commands/view/output.ts

@@ -3,7 +3,12 @@
  */
 import { z } from 'zod';
 
-import { EntityIdSchema } from '@/core/schemas/common-schemas';
+import {
+  EntityIdSchema,
+  NetworkSchema,
+  PublicKeySchema,
+  SupplyTypeSchema,
+} from '@/core/schemas/common-schemas';
 
 /**
  * Token Info Schema
@@ -14,10 +19,12 @@ export const ViewTokenOutputSchema = z.object({
   name: z.string(),
   symbol: z.string(),
   type: z.string(), // 'FUNGIBLE_COMMON' | 'NON_FUNGIBLE_UNIQUE'
+  network: NetworkSchema,
 
   // === Supply info (crucial for NFT - shows valid serial range) ===
   totalSupply: z.string(), // For NFT = current minted count
   maxSupply: z.string(),
+  supplyType: SupplyTypeSchema,
 
   // === Fungible Token specific ===
   decimals: z.number().optional(), // NFT doesn't have decimals
@@ -27,6 +34,10 @@ export const ViewTokenOutputSchema = z.object({
   memo: z.string().optional(),
   createdTimestamp: z.string().optional(),
 
+  // === Token keys ===
+  adminKey: PublicKeySchema.nullable().optional(),
+  supplyKey: PublicKeySchema.nullable().optional(),
+
   // === Specific NFT instance (when --serial provided) ===
   nftSerial: z
     .object({
@@ -54,19 +65,21 @@ export const VIEW_TOKEN_TEMPLATE = `
 
  Collection Info:
 
-   Token ID: {{tokenId}}
+   Token ID: {{hashscanLink tokenId "token" network}}
    Name: {{name}}
    Symbol: {{symbol}}
    Total Minted: {{totalSupply}}
+{{#if (eq supplyType "FINITE")}}
    Max Supply: {{maxSupply}}
+{{/if}}
 {{#if treasury}}
-   Treasury: {{treasury}}
+   Treasury: {{hashscanLink treasury "account" network}}
 {{/if}}
 
  NFT Details:
  
    Serial: #{{nftSerial.serialNumber}}
-   Owner: {{nftSerial.owner}}
+   Owner: {{hashscanLink nftSerial.owner "account" network}}
 {{#if nftSerial.createdTimestamp}}
    Created: {{nftSerial.createdTimestamp}}
 {{/if~}}
@@ -83,22 +96,32 @@ export const VIEW_TOKEN_TEMPLATE = `
 💰 Fungible Token
 {{/if}}
 
-   ID: {{tokenId}}
+   ID: {{hashscanLink tokenId "token" network}}
    Name: {{name}}
    Symbol: {{symbol}}
 
 {{#if (eq type "NON_FUNGIBLE_UNIQUE")}}
-   Current Supply: {{totalSupply}}{{#if (gt totalSupply "0")}} (Valid serials: 1 to {{totalSupply}}){{/if}}
+   Current Supply: {{totalSupply}}
+{{#if (eq supplyType "FINITE")}}
    Max Supply: {{maxSupply}}
+{{/if}}
 {{else}}
    Total Supply: {{totalSupply}}
+{{#if (eq supplyType "FINITE")}}
    Max Supply: {{maxSupply}}
+{{/if}}
 {{#if decimals}}
    Decimals: {{decimals}}
 {{/if~}}
 {{/if~}}
 {{#if treasury}}
-   Treasury: {{treasury}}
+   Treasury: {{hashscanLink treasury "account" network}}
+{{/if~}}
+{{#if adminKey}}
+   Admin Key: {{adminKey}}
+{{/if~}}
+{{#if supplyKey}}
+   Supply Key: {{supplyKey}}
 {{/if~}}
 {{#if memo}}
    Memo: {{memo}}

src/plugins/token/utils/nft-build-output.ts

@@ -1,4 +1,6 @@
 import type { NftInfo, TokenInfo } from '@/core/services/mirrornode/types';
+import type { SupportedNetwork } from '@/core/types/shared.types';
+import type { SupplyType } from '@/core/types/token.types';
 import type { ViewTokenOutput } from '@/plugins/token/commands/view';
 
 /**
@@ -47,17 +49,27 @@ function formatHederaTimestamp(timestamp?: string): string | undefined {
 export function buildOutput(
   tokenInfo: TokenInfo,
   nftInfo: NftInfo | null,
+  network: SupportedNetwork,
 ): ViewTokenOutput {
+  // Determine supply type based on max_supply
+  // If max_supply is "0", it's INFINITE, otherwise FINITE
+  const supplyType: SupplyType =
+    tokenInfo.max_supply === '0' ? 'INFINITE' : 'FINITE';
+
   const base = {
     tokenId: tokenInfo.token_id,
     name: tokenInfo.name,
     symbol: tokenInfo.symbol,
     type: tokenInfo.type,
+    network,
     totalSupply: tokenInfo.total_supply,
     maxSupply: tokenInfo.max_supply,
+    supplyType,
     treasury: tokenInfo.treasury || undefined,
     memo: tokenInfo.memo || undefined,
     createdTimestamp: formatHederaTimestamp(tokenInfo.created_timestamp),
+    adminKey: tokenInfo.admin_key?.key || null,
+    supplyKey: tokenInfo.supply_key?.key || null,
   };
 
   // Add decimals only for Fungible Tokens