feat(1540): Replace outdated key schemas with keySchema#1547
Open
feat(1540): Replace outdated key schemas with keySchema#1547
Conversation
matevszm
force-pushed
the
feat-1540/replace-outdated-key-schemas
branch
from
09127c4 to
2ac2971
Compare
mmyslblocky
requested changes
Mar 11, 2026
Contributor
mmyslblocky
left a comment
mmyslblocky
left a comment
There was a problem hiding this comment.
adjust description for KeySchema in every place
| token: EntityReferenceSchema.describe('Token identifier (ID or name)'), | ||
| account: PrivateKeyWithAccountIdSchema.describe( | ||
| account: KeySchema.describe( | ||
| 'Account to associate. Can be {accountId}:{privateKey pair}, key reference or account alias.', |
Contributor
There was a problem hiding this comment.
change description so that we can use any format of the key
| ), | ||
| adminKey: PrivateKeySchema.optional().describe( | ||
| adminKey: KeySchema.optional().describe( | ||
| 'Admin key of token. Can be {accountId}:{privateKey} pair, account private key in {ed25519|ecdsa}:private:{private-key} format, key reference or account alias. Defaults to operator key.', |
Contributor
There was a problem hiding this comment.
change description so that we can use any format of the key
| ), | ||
| adminKey: PrivateKeySchema.optional().describe( | ||
| adminKey: KeySchema.optional().describe( | ||
| 'Admin key of token. Can be {accountId}:{privateKey} pair, account private key in {ed25519|ecdsa}:private:{private-key} format, key reference or account alias. Defaults to operator key.', |
Contributor
There was a problem hiding this comment.
change description so that we can use any format of the key
| ), | ||
| supplyKey: PrivateKeySchema.describe( | ||
| supplyKey: KeySchema.describe( | ||
| 'Supply key. Can be {accountId}:{privateKey} pair, account private key in {ed25519|ecdsa}:private:{private-key} format, key reference or account alias.', |
Contributor
There was a problem hiding this comment.
change description so that we can use any format of the key
matevszm
force-pushed
the
feat-1540/replace-outdated-key-schemas
branch
from
2ac2971 to
d577320
Compare
Signed-off-by: matevszm <mateusz.marcinkowski@blockydevs.com>
matevszm
force-pushed
the
feat-1540/replace-outdated-key-schemas
branch
from
d577320 to
ad2be1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1540