fix: Handle INVALID_TRANSACTION together with FAIL_INVALID when Contract does not exists (#1990)

* handle INVALID_TRANSACTION together with FAIL_INVALID.
restoring disabled tests

Signed-off-by: Alfredo Gutierrez <[email protected]>

* Add UT for non-existent to address on relay call request, 2 response scenarios: FAIL_INVALID and INVALID_TRANSACTION

Signed-off-by: Alfredo Gutierrez <[email protected]>

* removing .only

Signed-off-by: Alfredo Gutierrez <[email protected]>

---------

Signed-off-by: Alfredo Gutierrez <[email protected]>

Author: AlfredoG87

packages/relay/src/lib/errors/MirrorNodeClientError.ts

@@ -87,4 +87,8 @@ export class MirrorNodeClientError extends Error {
   isFailInvalid() {
     return this.message === 'FAIL_INVALID';
   }
+
+  isInvalidTransaction() {
+    return this.message === 'INVALID_TRANSACTION';
+  }
 }

packages/relay/src/lib/eth.ts

@@ -1523,7 +1523,7 @@ export class EthImpl implements Eth {
 
       if (e instanceof MirrorNodeClientError) {
         // Handles mirror node error for missing contract
-        if (e.isFailInvalid()) {
+        if (e.isFailInvalid() || e.isInvalidTransaction()) {
           return EthImpl.emptyHex;
         }
 

packages/relay/tests/helpers.ts

@@ -299,6 +299,30 @@ const mockData = {
     },
   },
 
+  invalidTransaction: {
+    _status: {
+      messages: [
+        {
+          message: 'INVALID_TRANSACTION',
+          detail: '',
+          data: '',
+        },
+      ],
+    },
+  },
+
+  failInvalid: {
+    _status: {
+      messages: [
+        {
+          message: 'FAIL_INVALID',
+          detail: '',
+          data: '',
+        },
+      ],
+    },
+  },
+
   notSuported: {
     _status: {
       messages: [

packages/relay/tests/lib/eth/eth-config.ts

@@ -122,6 +122,7 @@ export const CONTRACT_ADDRESS_2 = '0x000000000000000000000000000000000000055e';
 export const CONTRACT_ADDRESS_3 = '0x000000000000000000000000000000000000255c';
 export const HTS_TOKEN_ADDRESS = '0x0000000000000000000000000000000002dca431';
 export const ACCOUNT_ADDRESS_1 = '0x13212A14deaf2775a5b3bEcC857806D5c719d3f2';
+export const NON_EXISTENT_CONTRACT_ADDRESS = `'0x55555555555555555555555555555555555555'`;
 export const DEFAULT_HTS_TOKEN = mockData.token;
 export const DEPLOYED_BYTECODE =
   '0x608060405234801561001057600080fd5b5060405161078938038061078983398181016040528101906100329190';

packages/relay/tests/lib/eth/eth_call.spec.ts

@@ -40,6 +40,7 @@ import {
   MAX_GAS_LIMIT,
   MAX_GAS_LIMIT_HEX,
   NO_TRANSACTIONS,
+  NON_EXISTENT_CONTRACT_ADDRESS,
   WRONG_CONTRACT_ADDRESS,
 } from './eth-config';
 import { JsonRpcError, predefined } from '../../../src/lib/errors/JsonRpcError';
@@ -820,5 +821,35 @@ describe('@ethCall Eth Call spec', async function () {
         args,
       );
     });
+
+    it('eth_call with all fields but mirrorNode throws 400 due to non-existent `to` address (INVALID_TRANSACTION)', async function () {
+      const callData = {
+        ...defaultCallData,
+        from: ACCOUNT_ADDRESS_1,
+        to: NON_EXISTENT_CONTRACT_ADDRESS,
+        data: CONTRACT_CALL_DATA,
+        gas: MAX_GAS_LIMIT,
+      };
+
+      web3Mock.onPost('contracts/call', { ...callData, estimate: false }).reply(400, mockData.invalidTransaction);
+      const result = await ethImpl.call(callData, 'latest');
+      expect(result).to.be.not.null;
+      expect(result).to.equal('0x');
+    });
+
+    it('eth_call with all fields but mirrorNode throws 400 due to non-existent `to` address (FAIL_INVALID)', async function () {
+      const callData = {
+        ...defaultCallData,
+        from: ACCOUNT_ADDRESS_1,
+        to: NON_EXISTENT_CONTRACT_ADDRESS,
+        data: CONTRACT_CALL_DATA,
+        gas: MAX_GAS_LIMIT,
+      };
+
+      web3Mock.onPost('contracts/call', { ...callData, estimate: false }).reply(400, mockData.failInvalid);
+      const result = await ethImpl.call(callData, 'latest');
+      expect(result).to.be.not.null;
+      expect(result).to.equal('0x');
+    });
   });
 });

packages/server/tests/acceptance/htsPrecompile/precompileCalls.spec.ts

@@ -614,7 +614,7 @@ describe('@precompile-calls Tests for eth_call with HTS', async function () {
     const CALLDATA_ALLOWANCE = '0xdd62ed3e';
     const NON_EXISTING_ACCOUNT = '123abc123abc123abc123abc123abc123abc123a';
 
-    xit('Call to non-existing HTS token returns 0x', async () => {
+    it('Call to non-existing HTS token returns 0x', async () => {
       const callData = {
         from: accounts[0].address,
         to: '0x' + NON_EXISTING_ACCOUNT,

packages/server/tests/acceptance/rpc_batch3.spec.ts

@@ -149,7 +149,7 @@ describe('@api-batch-3 RPC Server Acceptance Tests', function () {
       expect(res).to.eq('0x'); // confirm no error
     });
 
-    xit('"eth_call" for non-existing contract address returns 0x', async function () {
+    it('"eth_call" for non-existing contract address returns 0x', async function () {
       const callData = {
         from: accounts[0].address,
         to: Address.NON_EXISTING_ADDRESS,