chore: resolve comments

Signed-off-by: nikolay <n.atanasow94@gmail.com>

Author: natanasow

docs/configuration.md

@@ -92,7 +92,7 @@ Unless you need to set a non-default value, it is recommended to only populate o
 | `OPCODELOGGER_ENABLED`                                 | "true"                                                                                                                                                                                                   | Whether the `opcodeLogger` tracer is enabled for a call to `debug_traceTransaction`. This setting should match the value `hiero.mirror.web3.opcode.tracer.enabled` in the Mirror Node used. See [HIP-801](https://hips.hedera.com/hip/hip-801) for more information.                                                                                                                                                                                                                       |
 | `PAYMASTER_ENABLED`                                    | "false"                                                                                                                                                                                                  | Flag to enable or disable the Paymaster functionally                                                                                                                                                                                                                                                                                                                                                                                                                                       |
 | `PAYMASTER_WHITELIST`                                  | "[]"                                                                                                                                                                                                     | List of "to" addresses that will have fully subsidized transactions if the gasPrice was set to 0 by the signer                                                                                                                                                                                                                                                                                                                                                                             |
-| `PAYMASTER_ACCOUNTS`                                   | "[]"                                                                                                                                                                                                     | List of potential paymaster accounts that can be used alongside or instead of the default operator. Allows multiple paymasters without deploying separate instances per contract or address. Each entry defines [[accountId, type ("HEX_ECDSA", "HEX_ED25519"), key, allowance], [account, type, key, allowance]], e.g. `PAYMASTER_ACCOUNTS=[["0.0.9303","HEX_ECDSA","0x0000000000000000000000000000000000000000000000000000000000000000","80"],["0.0.5644","HEX_ECDSA","0x0000000000000000000000000000000000000000000000000000000000000000","100"]]` |
+| `PAYMASTER_ACCOUNTS`                                   | "[]"                                                                                                                                                                                                     | List of potential paymaster accounts that can be used alongside or instead of the default operator. Allows multiple paymasters without deploying separate instances per contract or address. Each entry defines [[accountId, type ("HEX_ECDSA", "HEX_ED25519"), key, allowanceInHBAR], [account, type, key, allowanceInHBAR]], e.g. `PAYMASTER_ACCOUNTS=[["0.0.9303","HEX_ECDSA","0x0000000000000000000000000000000000000000000000000000000000000000","80"],["0.0.5644","HEX_ECDSA","0x0000000000000000000000000000000000000000000000000000000000000000","350"]]` |
 | `PAYMASTER_ACCOUNTS_WHITELISTS`                        | "[]"                                                                                                                                                                                                     | Defines the address (smart contract or account) whitelists for each paymaster account. Each entry maps a paymaster account to an array of addresses it can pay for. Duplicates are overridden by the last configured paymaster. Each entry defines [[accountId, [addressA, addressB]], e.g. `PAYMASTER_ACCOUNTS_WHITELISTS=[["0.0.9303",["0x0000000000000000000000000000000000000062","0x0000000000000000000000000000000000000320"]],["0.0.5644",["0x0000000000000000000000000000000000000001"]]]` |
 | `READ_ONLY`                                            | "false"                                                                                                                                                                                                  | Starts the JSON-RPC Relay in Read-Only mode. In Read-Only mode, write operations, _e.g._, `eth_sendRawTransaction` or query operations to the Consensus Node will trigger an `Unsupported operation` error.                                                                                                                                                                                                                                                                                |
 | `REDIS_ENABLED`                                        | "true"                                                                                                                                                                                                   | Enable usage of Redis as shared cache                                                                                                                                                                                                                                                                                                                                                                                                                                                      |

packages/config-service/src/services/loggerService.ts

@@ -1,5 +1,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
+import { PaymasterAccount } from '@hashgraph/json-rpc-relay/dist/lib/services';
+
 import { ConfigKey, GlobalConfig } from './globalConfig';
 
 export class LoggerService {
@@ -14,15 +16,21 @@ export class LoggerService {
    * @param envName
    * @param envValue
    */
-  static maskUpEnv(envName: string, envValue: string | undefined): string {
+  static maskUpEnv(envName: string, envValue: string | undefined | string[][]): string {
     const isSensitiveField: boolean = (this.SENSITIVE_FIELDS as string[]).indexOf(envName) > -1;
     const isKnownSecret: boolean =
-      GlobalConfig.ENTRIES[envName].type === 'string' && !!this.GITHUB_SECRET_PATTERN.exec(envValue ?? '');
+      GlobalConfig.ENTRIES[envName].type === 'string' &&
+      typeof envValue === 'string' &&
+      !!this.GITHUB_SECRET_PATTERN.exec(envValue ?? '');
 
     if (isSensitiveField || isKnownSecret) {
       return `${envName} = **********`;
     }
 
+    if (envName === 'PAYMASTER_ACCOUNTS') {
+      return `${envName} = [${(envValue as PaymasterAccount[]).map((a) => `[${a[0]},${a[1]},**********,${a[3]}]`)}]`;
+    }
+
     return `${envName} = ${envValue}`;
   }
 }

packages/config-service/tests/src/services/loggerService.spec.ts

@@ -24,4 +24,30 @@ describe('LoggerService tests', async function () {
 
     expect(LoggerService.maskUpEnv(envName, res)).to.equal(`${envName} = ${res}`);
   });
+
+  it('should mast private keys in PAYMASTER_ACCOUNTS', async () => {
+    const paymaster0 = [
+      '0.0.801',
+      'HEX_ECDSA',
+      '0x1111111111111111111111111111111111111111111111111111111111111111',
+      '300',
+    ];
+    const paymaster1 = [
+      '0.0.802',
+      'HEX_ECDSA',
+      '0x2222222222222222222222222222222222222222222222222222222222222222',
+      '200',
+    ];
+    const res = LoggerService.maskUpEnv('PAYMASTER_ACCOUNTS', [paymaster0, paymaster1]);
+
+    expect(res).to.contain(paymaster0[0]);
+    expect(res).to.contain(paymaster1[0]);
+    expect(res).to.contain(paymaster0[3]);
+    expect(res).to.contain(paymaster1[3]);
+
+    expect(res.match(/\*{10}/g).length).to.equal(2);
+    expect(res.match(/HEX_ECDSA/g).length).to.equal(2);
+    expect(res).to.not.contain(paymaster0[2]);
+    expect(res).to.not.contain(paymaster1[2]);
+  });
 });