Productize ETH_POPULATE_SYNTHETIC_CONTRACT_RESULTS = true (#1788) (#1790)

productising ETH_POPULATE_SYNTHETIC_CONTRACT_RESULTS = true, as it has been running on production environments from some time without issues.

Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Co-authored-by: Alfredo Gutierrez <[email protected]>

Author: ebadiere

docs/configuration.md

@@ -44,7 +44,7 @@ The following table lists the available properties along with their default valu
 Unless you need to set a non-default value, it is recommended to only populate overridden properties in the custom `.env`.
 
 | Name                                        | Default                  | Description                                                                                                                                                                                                                                                                                            |
-| ------------------------------------------- | ------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
+| ------------------------------------------- |--------------------------| ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
 | `CACHE_MAX`                                 | "1000"                   | The maximum number (or size) of items that remain in the cache (assuming no TTL pruning or explicit deletions).                                                                                                                                                                                        |
 | `CACHE_TTL`                                 | "3_600_000"              | Max time to live in ms, for items before they are considered stale. Default is one hour in milliseconds                                                                                                                                                                                                |
 | `CLIENT_TRANSPORT_SECURITY`                 | "false"                  | Flag to enable or disable TLS for both networks.                                                                                                                                                                                                                                                       |
@@ -60,7 +60,7 @@ Unless you need to set a non-default value, it is recommended to only populate o
 | `ETH_GET_TRANSACTION_COUNT_MAX_BLOCK_RANGE` | "1000"                   | The maximum number of transactions to return when running eth_getBlockByHash or eth_getBlockByNumber with transaction objects set to true call.                                                                                                                                                        |
 | `FEE_HISTORY_MAX_RESULTS`                   | "10"                     | The maximum number of results to returns as part of `eth_feeHistory`.                                                                                                                                                                                                                                  |
 | `ETH_FEE_HISTORY_FIXED`                     | "true"                   | Flag to set if eth_feeHistory should return a fixed fee for the set of results.                                                                                                                                                                                                                        |
-| `ETH_POPULATE_SYNTHETIC_CONTRACT_RESULTS`   | false                    | Flag to set if the relay should populate the contract results for synthetic contracts.                                                                                                                                                                                                                 |
+| `ETH_POPULATE_SYNTHETIC_CONTRACT_RESULTS`   | "true"                   | Flag to set if the relay should populate the contract results for synthetic contracts.                                                                                                                                                                                                                 |
 | `GAS_PRICE_TINY_BAR_BUFFER`                 | "10000000000"            | The additional buffer range to allow during a relay precheck of gas price. This supports slight fluctuations in network gasprice calculations.                                                                                                                                                         |
 | `HAPI_CLIENT_DURATION_RESET`                | "3600000"                | Time until client reinitialization. (ms)                                                                                                                                                                                                                                                               |
 | `HAPI_CLIENT_ERROR_RESET`                   | [50]                     | Array of status codes, which when encountered will trigger a reinitialization. Status codes are availble [here](https://github.com/hashgraph/hedera-protobufs/blob/main/services/response_code.proto).                                                                                                 |

packages/relay/src/lib/eth.ts

@@ -157,7 +157,7 @@ export class EthImpl implements Eth {
   );
   private readonly shouldPopulateSyntheticContractResults = process.env.ETH_POPULATE_SYNTHETIC_CONTRACT_RESULTS
     ? process.env.ETH_POPULATE_SYNTHETIC_CONTRACT_RESULTS === 'true'
-    : false;
+    : true;
   /**
    * Configurable options used when initializing the cache.
    *