fix: throw COULD_NOT_SIMULATE_TRANSACTION for eth_gasPrice

Signed-off-by: Logan Nguyen <[email protected]>

Author: quiet-node

packages/relay/src/lib/services/ethService/contractService/ContractService.ts

@@ -16,7 +16,6 @@ import constants from '../../../constants';
 import { JsonRpcError, predefined } from '../../../errors/JsonRpcError';
 import { MirrorNodeClientError } from '../../../errors/MirrorNodeClientError';
 import { Log } from '../../../model';
-import { Precheck } from '../../../precheck';
 import { IContractCallRequest, IContractCallResponse, IGetLogsParams, RequestDetails } from '../../../types';
 import { CacheService } from '../../cacheService/cacheService';
 import { CommonService } from '../../ethService/ethCommonService/CommonService';
@@ -525,14 +524,12 @@ export class ContractService implements IContractService {
     }
 
     if (e.isContractRevert()) {
-      if (this.logger.isLevelEnabled('trace')) {
-        this.logger.trace(
-          `mirror node eth_call request encountered contract revert. message: ${e.message}, details: ${e.detail}, data: ${e.data}`,
-        );
-      }
-      return predefined.CONTRACT_REVERT(e.detail || e.message, e.data);
+      throw predefined.CONTRACT_REVERT(e.detail || e.message, e.data);
+    } else if (e.statusCode === 400) {
+      throw predefined.COULD_NOT_SIMULATE_TRANSACTION(e.detail || e.message);
     }
-    // for any other Mirror Node upstream server errors (429, 500, 502, 503, 504, etc.), preserve the original error and re-throw to the upper layer
+
+    // for any other Mirror Node upstream server errors (429, 500, 502, 503, 504, etc.), preserve the original error and re-throw to the upper layer for further handling logic
     throw e;
   }
 

packages/relay/src/lib/services/ethService/ethCommonService/CommonService.ts

@@ -458,7 +458,7 @@ export class CommonService implements ICommonService {
       }
     }
 
-    throw predefined.COULD_NOT_ESTIMATE_GAS_PRICE('Failed to retrieve gas price from network fees');
+    throw predefined.INTERNAL_ERROR('Failed to retrieve gas price from network fees');
   }
 
   /**

packages/relay/tests/lib/eth/eth_gasPrice.spec.ts

@@ -84,7 +84,7 @@ describe('@ethGasPrice Gas Price spec', async function () {
 
       restMock.onGet(`network/fees`).reply(200, JSON.stringify(partialNetworkFees));
       await RelayAssertions.assertRejection(
-        predefined.COULD_NOT_ESTIMATE_GAS_PRICE('Failed to retrieve gas price from network fees'),
+        predefined.INTERNAL_ERROR('Failed to retrieve gas price from network fees'),
         ethImpl.gasPrice,
         true,
         ethImpl,
@@ -140,7 +140,7 @@ describe('@ethGasPrice Gas Price spec', async function () {
 
       it('eth_gasPrice with no network fees records found', async function () {
         await RelayAssertions.assertRejection(
-          predefined.COULD_NOT_ESTIMATE_GAS_PRICE('Failed to retrieve gas price from network fees'),
+          predefined.INTERNAL_ERROR('Failed to retrieve gas price from network fees'),
           ethImpl.gasPrice,
           true,
           ethImpl,

packages/server/tests/acceptance/htsPrecompile/precompileCalls.spec.ts

@@ -741,7 +741,11 @@ describe('@precompile-calls Tests for eth_call with HTS', async function () {
         data: CALLDATA_BALANCE_OF + NON_EXISTING_ACCOUNT.padStart(64, '0'),
       };
 
-      await relay.callFailing(Constants.ETH_ENDPOINTS.ETH_CALL, [callData, 'latest'], predefined.CONTRACT_REVERT());
+      await relay.callFailing(
+        Constants.ETH_ENDPOINTS.ETH_CALL,
+        [callData, 'latest'],
+        predefined.COULD_NOT_SIMULATE_TRANSACTION('Sender account not found.'),
+      );
     });
 
     it('Call to allowance method of an HTS token with non-existing owner account in call data returns error', async () => {