Skip to content

Commit 494f6c1

Browse files
authored
Merge branch 'main' into 4630-review-the-200-and-400-http-code
2 parents 192fb00 + 2e9648a commit 494f6c1

File tree

42 files changed

+654
-664
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+654
-664
lines changed

.github/workflows/postman.yml

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
name: Postman Endpoint Tests
22

3+
# Disabled newman temporarily
34
on:
4-
pull_request:
5-
branches: [ main, release/** ]
6-
push:
7-
branches: [ main, release/** ]
8-
tags: [ v* ]
5+
workflow_dispatch: # Manual trigger only
6+
# Disabled triggers:
7+
# pull_request:
8+
# branches: [ main, release/** ]
9+
# push:
10+
# branches: [ main, release/** ]
11+
# tags: [ v* ]
912

1013
concurrency:
1114
group: pr-checks-${{ github.workflow }}-${{ github.head_ref || github.run_id }}
@@ -59,8 +62,14 @@ jobs:
5962
- name: Start the local relay
6063
run: npm run start &
6164

62-
- name: Install newman
63-
run: npm install -g newman
65+
# - name: Install newman
66+
# run: npm install -g newman
6467

65-
- name: Run the newman script
66-
run: newman run packages/server/tests/postman.json
68+
# - name: Run the newman script
69+
# run: newman run packages/server/tests/postman.json
70+
71+
- name: Security Warning
72+
run: |
73+
echo "CRITICAL: This workflow is disabled due to Newman security compromise"
74+
echo "DO NOT re-enable until Newman is replaced with a secure alternative"
75+
exit 1

README.md

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -50,24 +50,6 @@ run configuration. You should be able to just run that configuration, and it sho
5050

5151
- It is highly recommended to read the [Testing Guide](docs/testing-guide.md) for detailed testing strategies and best practices.
5252

53-
### Postman
54-
55-
First ensure newman is installed locally using `npm`, then execute `newman`.
56-
57-
```shell
58-
npm install -g newman
59-
newman run packages/server/tests/postman.json --env-var baseUrl=http://localhost:7546
60-
```
61-
62-
To enable Postman test to run via helm deployment add
63-
64-
```
65-
test:
66-
enabled: true
67-
schedule: '@daily' #How often to run the Postman test
68-
baseUrl: "http://127.0.0.1:7546" # Relay URL to run the test against
69-
```
70-
7153
### Acceptance Tests
7254

7355
The relay has a suite of acceptance tests that may be run to confirm E2E operation of the relay in either a `hedera-local-node` or deployed env.

charts/hedera-json-rpc-relay/templates/cronjob.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ spec:
2727
{{- end }}
2828

2929
---
30-
{{- if .Values.cronjob.enabled }}
30+
# Disabled newman temporarily
31+
{{- if false }} # Force disabled - was: .Values.cronjob.enabled
3132
apiVersion: batch/v1
3233
kind: CronJob
3334
metadata:

charts/hedera-json-rpc-relay/templates/tests/pod.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
{{- if .Values.test.enabled -}}
1+
# Disabled newman temporarily
2+
{{- if false }} # Force disabled - was: .Values.test.enabled
23
apiVersion: v1
34
kind: Pod
45
metadata:

charts/hedera-json-rpc-relay/values.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ redis:
138138
# REDIS_URL=redis://<release-name>-redis-master:6379
139139
autoconfig: true
140140

141+
# Disabled newman temporarily
141142
cronjob:
142143
enabled: false
143144
image:
@@ -245,8 +246,9 @@ readinessProbe:
245246
initialDelaySeconds: 20
246247
timeoutSeconds: 5
247248

249+
# Disabled newman temporarily
248250
test:
249-
enabled: true
251+
enabled: false
250252
image:
251253
pullPolicy: IfNotPresent
252254
repository: postman/newman

0 commit comments

Comments
 (0)