change so we only retry on 404s if a retry is desired (#1194) (#1206)

* change so we only retry on 404s if  a retry is desired



* moved the retryable codes to the mirrorNodeClient.ts and make it a configurable list with default being  only 404


* refactored const name so  is  more  descriptive to mirrorNodeRetryErrorCodes


---------

Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Co-authored-by: Alfredo Gutierrez <[email protected]>

Author: ebadiere

docs/configuration.md

@@ -42,7 +42,7 @@ The following table lists the available properties along with their default valu
 Unless you need to set a non-default value, it is recommended to only populate overridden properties in the custom `.env`.
 
 | Name                                  | Default       | Description                                                                                                                                                                                                                                                                                            |
-| ------------------------------------- | ------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
+|---------------------------------------| ------------- |--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | `CLIENT_TRANSPORT_SECURITY`           | "false"       | Flag to enable or disable TLS for both networks.                                                                                                                                                                                                                                                       |
 | `CONSENSUS_MAX_EXECUTION_TIME`        | "15000"       | Maximum time in ms the SDK will wait when submitting a transaction/query before throwing a TIMEOUT error.                                                                                                                                                                                              |
 | `DEFAULT_RATE_LIMIT`                  | "200"         | default fallback rate limit, if no other is configured.                                                                                                                                                                                                                                                |
@@ -57,6 +57,7 @@ Unless you need to set a non-default value, it is recommended to only populate o
 | `LIMIT_DURATION`                      | "60000"       | The maximum duration in ms applied to IP-method based rate limits.                                                                                                                                                                                                                                     |
 | `MIRROR_NODE_LIMIT_PARAM`             | "100"         | The mirror node custom limit value to be set on GET requests. This optimizes the flow to reduce the number of calls made to the mirror node by setting a limit larger than it's default limit.                                                                                                         |
 | `MIRROR_NODE_RETRIES`                 | "3"           | The maximum number of retries on a GET request to the mirror node when an acceptable error code is returned.                                                                                                                                                                                           |
+| `MIRROR_NODE_RETRY_CODES`             | "[404]"       | The acceptable error codes to retry on a request to the mirror node. If more than 1 error is defined value should be like ie: [400,404,500]                                                                                                                                                            | 
 | `MIRROR_NODE_RETRY_DELAY`             | "250"         | The delay in ms between retry requests.                                                                                                                                                                                                                                                                |
 | `MIRROR_NODE_RETRIES_DEVMODE`         | "5"           | The maximum number of retries on a GET request to the mirror node when an acceptable error code is returned in dev mode.                                                                                                                                                                               |
 | `MIRROR_NODE_RETRY_DELAY_DEVMODE`     | "200"         | The delay in ms between retry requests in dev mode.                                                                                                                                                                                                                                                    |

packages/relay/src/lib/clients/mirrorNodeClient.ts

@@ -147,6 +147,7 @@ export class MirrorNodeClient {
         const mirrorNodeRetriesDevMode = parseInt(process.env.MIRROR_NODE_RETRIES_DEVMODE!) || 5;
         const mirrorNodeRetryDelay = parseInt(process.env.MIRROR_NODE_RETRY_DELAY!) || 250;
         const mirrorNodeRetryDelayDevMode = parseInt(process.env.MIRROR_NODE_RETRY_DELAY_DEVMODE!) || 200;
+        const mirrorNodeRetryErrorCodes: Array<number> = process.env.MIRROR_NODE_RETRY_CODES ? JSON.parse(process.env.MIRROR_NODE_RETRY_CODES) : [404]; // by default we should only retry on 404 errors
 
         const axiosClient: AxiosInstance = Axios.create({
             baseURL: baseUrl,
@@ -184,7 +185,7 @@ export class MirrorNodeClient {
                 return delay;
             },
             retryCondition: (error) => {
-                return !error?.response?.status || MirrorNodeClientError.retryErrorCodes.includes(error?.response?.status);
+                return !error?.response?.status || mirrorNodeRetryErrorCodes.includes(error?.response?.status);
             },
             shouldResetTimeout: true
         });

packages/relay/src/lib/errors/MirrorNodeClientError.ts

@@ -23,8 +23,6 @@ export class MirrorNodeClientError extends Error {
     public statusCode: number;
     public errorMessage?: string;
 
-    static retryErrorCodes: Array<number> = [400, 404, 408, 425, 500]
-
     static ErrorCodes = {
       ECONNABORTED: 504,
       CONTRACT_REVERT_EXECUTED : 400,