Change v field in eth_getTransactionByHash and eth_getBlockByHash to be zeroHex instead of null (#917)

* Change null to 0x

Signed-off-by: Major <[email protected]>
Signed-off-by: Major <[email protected]>

* Added test for 0x0 value when v is null

Signed-off-by: Major <[email protected]>

---------

Signed-off-by: Major <[email protected]>
Signed-off-by: Major <[email protected]>

Author: sergioaiobuilders

packages/relay/src/lib/eth.ts

@@ -1101,7 +1101,7 @@ export class EthImpl implements Eth {
       to: contractResult.to?.substring(0, 42),
       transactionIndex: EthImpl.numberTo0x(contractResult.transaction_index),
       type: EthImpl.nullableNumberTo0x(contractResult.type),
-      v: EthImpl.nullableNumberTo0x(contractResult.v),
+      v: EthImpl.nanOrNumberTo0x(contractResult.v),
       value: EthImpl.nanOrNumberTo0x(contractResult.amount),
     });
   }
@@ -1382,7 +1382,7 @@ export class EthImpl implements Eth {
             to: contractResultDetails.to.substring(0, 42),
             transactionIndex: EthImpl.numberTo0x(contractResultDetails.transaction_index),
             type: EthImpl.nullableNumberTo0x(contractResultDetails.type),
-            v: EthImpl.nullableNumberTo0x(contractResultDetails.v),
+            v: EthImpl.nanOrNumberTo0x(contractResultDetails.v),
             value: EthImpl.nanOrNumberTo0x(contractResultDetails.amount),
           });
         }

packages/relay/tests/lib/eth.spec.ts

@@ -3320,6 +3320,24 @@ describe('Eth', async function () {
       expect(result.value).to.eq('0x0');
     });
 
+    it('handles transactions with v as null', async function () {
+      // mirror node request mocks
+      const detailedResultsWithNullNullableValues = {
+        ...defaultDetailedContractResultByHash,
+        v: null
+      };
+
+      restMock.onGet(`contracts/results/${defaultTxHash}`).reply(200, detailedResultsWithNullNullableValues);
+      restMock.onGet(`accounts/${defaultFromLongZeroAddress}`).reply(200, {
+        evm_address: `${defaultTransaction.from}`
+      });
+      const result = await ethImpl.getTransactionByHash(defaultTxHash);
+      if (result == null) return;
+
+      expect(result).to.exist;
+      expect(result.v).to.eq('0x0');
+    });
+
     it('returns reverted transactions', async function () {
       restMock.onGet(`contracts/results/${defaultTxHash}`).reply(200, defaultDetailedContractResultByHashReverted);
       restMock.onGet(`accounts/${defaultFromLongZeroAddress}`).reply(200, {