Cherry pick #846 - gas_estimate fix (#847)

Fix validations for estimateGas (#846)

* fix validation for estimateGas

Signed-off-by: georgi-l95 <[email protected]>

* fix duplication

Signed-off-by: georgi-l95 <[email protected]>

* fix duplication

Signed-off-by: georgi-l95 <[email protected]>

Signed-off-by: georgi-l95 <[email protected]>

Signed-off-by: georgi-l95 <[email protected]>
Co-authored-by: georgi-l95 <[email protected]>

Author: lukelee-sl

packages/server/src/validator/objectTypes.ts

@@ -65,6 +65,9 @@ export const OBJECTS_VALIDATIONS = {
     },
     "input": {
       type: "hex"
+    },
+    "accessList": {
+      type: "array"
     }
   }
 };

packages/server/tests/acceptance/rpc.spec.ts

@@ -920,6 +920,115 @@ describe('@api RPC Server Acceptance Tests', function () {
                 expect(res).to.not.be.equal('0x');
                 expect(res).to.not.be.equal('0x0');
             });
+
+            it('should execute "eth_estimateGas" with to, from, value and gas filed', async function () {
+                const res = await relay.call('eth_estimateGas', [{
+                    from: '0x114f60009ee6b84861c0cdae8829751e517bc4d7',
+                    to: '0xae410f34f7487e2cd03396499cebb09b79f45d6e',
+                    value: '0xa688906bd8b00000',
+                    gas: '0xd97010'
+                   }], requestId);
+                expect(res).to.contain('0x');
+                expect(res).to.not.be.equal('0x');
+                expect(res).to.not.be.equal('0x0');
+            });
+
+            it('should execute "eth_estimateGas" with to, from, value,accessList gas filed', async function () {
+                const res = await relay.call('eth_estimateGas', [{
+                    from: '0x114f60009ee6b84861c0cdae8829751e517bc4d7',
+                    to: '0xae410f34f7487e2cd03396499cebb09b79f45d6e',
+                    value: '0xa688906bd8b00000',
+                    gas: '0xd97010',
+                    accessList: []
+                   }], requestId);
+                expect(res).to.contain('0x');
+                expect(res).to.not.be.equal('0x');
+                expect(res).to.not.be.equal('0x0');
+            });
+
+            it('should not be able to execute "eth_estimateGas" with no transaction object', async function () {
+                try {
+                    await relay.call('eth_estimateGas', [], requestId);
+                    Assertions.expectedError();
+                } catch (error) {
+                    const err = JSON.parse(error.body);
+                    expect(error).to.not.be.null;
+                    expect(err.error.name).to.be.equal('Missing required parameters');
+                    expect(err.error.message.endsWith('Missing value for required parameter 0')).to.be.true;
+                } 
+            });
+
+            it('should not be able to execute "eth_estimateGas" with wrong from field', async function () {
+                try {
+                    await relay.call('eth_estimateGas', [{
+                        from: '0x114f60009ee6b84861c0cdae8829751e517bc4d7',
+                        to: '0xae410f34f7487e2cd03396499cebb09b79f45',
+                        value: '0xa688906bd8b00000',
+                        gas: '0xd97010',
+                        accessList: []
+                       }], requestId);
+                    Assertions.expectedError();
+                } catch (error) {
+                    const err = JSON.parse(error.body);
+                    expect(error).to.not.be.null;
+                    expect(err.error.name).to.be.equal('Invalid parameter');
+                    expect(err.error.message.endsWith(`Invalid parameter 'to' for TransactionObject: Expected 0x prefixed string representing the address (20 bytes)`)).to.be.true;
+                }
+            });
+
+            it('should not be able to execute "eth_estimateGas" with wrong to field', async function () {
+                try {
+                    await relay.call('eth_estimateGas', [{
+                        from: '0x114f60009ee6b84861c0cdae8829751e517bc4d7',
+                        to: '0xae410f34f7487e2cd03396499cebb09b79f45',
+                        value: '0xa688906bd8b00000',
+                        gas: '0xd97010',
+                        accessList: []
+                       }], requestId);
+                    Assertions.expectedError();
+                } catch (error) {
+                    const err = JSON.parse(error.body);
+                    expect(error).to.not.be.null;
+                    expect(err.error.name).to.be.equal('Invalid parameter');
+                    expect(err.error.message.endsWith(`Invalid parameter 'to' for TransactionObject: Expected 0x prefixed string representing the address (20 bytes)`)).to.be.true;
+                } 
+            });
+
+            it('should not be able to execute "eth_estimateGas" with wrong value field', async function () {
+                try {
+                    await relay.call('eth_estimateGas', [{
+                        from: '0x114f60009ee6b84861c0cdae8829751e517bc4d7',
+                        to: '0xae410f34f7487e2cd03396499cebb09b79f45d6e',
+                        value: '123',
+                        gas: '0xd97010',
+                        accessList: []
+                       }], requestId);
+                    Assertions.expectedError();
+                } catch (error) {
+                    const err = JSON.parse(error.body);
+                    expect(error).to.not.be.null;
+                    expect(err.error.name).to.be.equal('Invalid parameter');
+                    expect(err.error.message.endsWith(`Invalid parameter 'value' for TransactionObject: Expected 0x prefixed hexadecimal value`)).to.be.true;
+                } 
+            });
+
+            it('should not be able to execute "eth_estimateGas" with wrong gas field', async function () {
+                try {
+                    await relay.call('eth_estimateGas', [{
+                        from: '0x114f60009ee6b84861c0cdae8829751e517bc4d7',
+                        to: '0xae410f34f7487e2cd03396499cebb09b79f45d6e',
+                        value: '0xa688906bd8b00000',
+                        gas: '123',
+                        accessList: []
+                       }], requestId);
+                    Assertions.expectedError();
+                } catch (error) {
+                    const err = JSON.parse(error.body);
+                    expect(error).to.not.be.null;
+                    expect(err.error.name).to.be.equal('Invalid parameter');
+                    expect(err.error.message.endsWith(`Invalid parameter 'gas' for TransactionObject: Expected 0x prefixed hexadecimal value`)).to.be.true;
+                } 
+            });
         });
 
         describe('eth_gasPrice', async function () {