feat: improve error handling in SDKClient.executeTransaction to preserve original error details (#4376)

Signed-off-by: nikolay <[email protected]>

Author: natanasow

packages/relay/src/lib/clients/sdkClient.ts

@@ -329,15 +329,7 @@ export class SDKClient {
       }
 
       if (!transactionResponse) {
-        // Transactions may experience "SDK timeout exceeded" or "Connection Dropped" errors from the SDK, yet they may still be able to reach the consensus layer.
-        // Throw Connection Drop and Timeout errors as additional handling logic is expected in a higher layer.
-        if (sdkClientError.isConnectionDropped() || sdkClientError.isTimeoutExceeded()) {
-          throw sdkClientError;
-        } else {
-          throw predefined.INTERNAL_ERROR(
-            `Transaction execution returns a null value: transactionId=${transaction.transactionId}, callerName=${callerName}, txConstructorName=${txConstructorName}`,
-          );
-        }
+        throw sdkClientError;
       }
       return transactionResponse;
     } finally {

packages/relay/tests/lib/sdkClient.spec.ts

@@ -435,6 +435,22 @@ describe('SdkClient', async function () {
         await expect(callSubmit(buffer)).to.be.rejectedWith(SDKClientError, 'No fileId created for transaction.');
       });
     });
+
+    it('should wrap every error in a SDKClientError if transaction execution fails', async () => {
+      sinon.stub(EthereumTransaction.prototype, 'execute').throwsException();
+
+      expect(
+        sdkClient.executeTransaction(
+          new EthereumTransaction().setCallDataFileId(fileId).setEthereumData(transactionBuffer),
+          mockedCallerName,
+          requestDetails,
+          true,
+          randomAccountAddress,
+        ),
+      ).to.eventually.be.rejected.and.satisfy((err: any) => {
+        expect(err?.constructor?.name).to.equal(SDKClientError.constructor.name);
+      });
+    });
   });
 
   describe('HBAR Limiter', async () => {