Fix SDK reinitialization (#1252)

* fix sdk instance reinit

Signed-off-by: georgi-l95 <[email protected]>

* add invalid transaction body error logging

Signed-off-by: georgi-l95 <[email protected]>

* add log switch

Signed-off-by: georgi-l95 <[email protected]>

---------

Signed-off-by: georgi-l95 <[email protected]>

Author: georgi-l95

.env.example

@@ -42,3 +42,4 @@ WS_MULTIPLE_ADDRESSES_ENABLED=
 ETH_BLOCK_NUMBER_CACHE_TTL_MS=
 ETH_GET_BALANCE_CACHE_TTL_MS=
 ETH_FEE_HISTORY_FIXED=
+TRACE_LOG_INVALID_TRANSACTION_BODY=

helm-chart/templates/configmap.yaml

@@ -37,3 +37,4 @@ data:
   SUBSCRIPTIONS_ENABLED: {{ .Values.config.SUBSCRIPTIONS_ENABLED | quote }}
   ETH_CALL_DEFAULT_TO_CONSENSUS_NODE: {{ .Values.config.ETH_CALL_DEFAULT_TO_CONSENSUS_NODE | quote }}
   CONTRACT_QUERY_TIMEOUT_RETRIES: {{ .Values.config.CONTRACT_QUERY_TIMEOUT_RETRIES | quote }}
+  TRACE_LOG_INVALID_TRANSACTION_BODY: {{ .Values.config.TRACE_LOG_INVALID_TRANSACTION_BODY | quote }}

helm-chart/value-test.yaml

@@ -126,6 +126,7 @@ config:
   CONTRACT_QUERY_TIMEOUT_RETRIES: 3
   SUBSCRIPTIONS_ENABLED: false
   ETH_CALL_DEFAULT_TO_CONSENSUS_NODE: false
+  TRACE_LOG_INVALID_TRANSACTION_BODY: true
 
 # Enable rolling_restarts if SDK calls fail this is usually due to stale connections that get cycled on restart
 rolling_restart:

helm-chart/values.yaml

@@ -127,6 +127,7 @@ config:
   CONTRACT_QUERY_TIMEOUT_RETRIES: 3
   SUBSCRIPTIONS_ENABLED: false
   ETH_CALL_DEFAULT_TO_CONSENSUS_NODE: true
+  TRACE_LOG_INVALID_TRANSACTION_BODY: true
 
 # Enable rolling_restarts if SDK calls fail this is usually due to stale connections that get cycled on restart
 rolling_restart:

packages/relay/src/lib/clients/sdkClient.ts

@@ -455,6 +455,11 @@ export class SDKClient {
             if (sdkClientError.isGrpcTimeout()) {
                 throw predefined.REQUEST_TIMEOUT;
             }
+
+            if (sdkClientError.isInvalidTransactionBody() && process.env.TRACE_LOG_INVALID_TRANSACTION_BODY) {
+                this.logger.error(`${requestIdPrefix} Query object on InvalidTransactionBody error:  ${JSON.stringify(query)}`);
+                this.logger.error(`${requestIdPrefix} Client object on InvalidTransactionBody error: ${JSON.stringify({...client, _timer: undefined})}`);
+            }
             throw sdkClientError;
         }
     };

packages/relay/src/lib/errors/SDKClientError.ts

@@ -68,5 +68,9 @@ export class SDKClientError extends Error {
     // The SDK uses the same code for Grpc Timeout as INVALID_TRANSACTION_ID
     return this.statusCode === Status.InvalidTransactionId._code;
   }
+
+  public isInvalidTransactionBody(): boolean {
+    return this.statusCode === Status.InvalidTransactionBody._code;
+  }
 }
 

packages/relay/src/lib/eth.ts

@@ -168,7 +168,7 @@ export class EthImpl implements Eth {
   /* Temporary code duplication for a temporary HotFix workaround while the definitive  fix is implemented
   * Please remove initClient workaround, or better yet, do not let this be merged on MAIN, short-lived fix intended only for 0.23.1 version */
   private requestsPerSdkClient = 0;
-  private maxRequestsPerSdkClient = process.env.ETH_CALL_MAX_REQUEST_PER_SDK_INSTANCE || 50;
+  private maxRequestsPerSdkClient = parseInt(process.env.ETH_CALL_MAX_REQUEST_PER_SDK_INSTANCE!) || 50;
   private hederaNetwork: string = (process.env.HEDERA_NETWORK || '{}').toLowerCase();
   private ethSdkClient: SDKClient | undefined;
   private isInTest = typeof global.it === 'function';
@@ -184,7 +184,7 @@ export class EthImpl implements Eth {
 
     // if we have reached the max number of requests per sdk client instance, or if the sdk client instance is undefined, create a new one
     if (this.requestsPerSdkClient >= this.maxRequestsPerSdkClient || this.ethSdkClient == undefined) {
-      this.ethSdkClient = new SDKClient(this.hederaClient, this.logger, this.registry);
+      this.ethSdkClient = new SDKClient(SDKClient.initClient(this.logger, this.hederaNetwork), this.logger, this.registry);
       this.requestsPerSdkClient = 0;
       this.logger.debug(`Limit of requests per instance ${this.maxRequestsPerSdkClient} was reached. Created new SDK client instance`);
     }