feat: fail when sending a transaction with non empty acess list (#4651)

Signed-off-by: Mariusz Jasuwienas <[email protected]>

Author: jasuwienas

packages/relay/src/lib/precheck.ts

@@ -77,6 +77,7 @@ export class Precheck {
       mirrorAccountInfo.ethereum_nonce + (await this.transactionPoolService.getPendingCount(parsedTx.from!));
     this.nonce(parsedTx, signerNonce);
     this.balance(parsedTx, mirrorAccountInfo.balance);
+    this.accessList(parsedTx);
     await this.receiverAccount(parsedTx, requestDetails);
   }
 
@@ -214,6 +215,14 @@ export class Precheck {
     }
   }
 
+  /**
+   * Checks if the value of the access was not set.
+   * @param tx - The transaction.
+   */
+  accessList(tx: Transaction): void {
+    if (tx.accessList?.length) throw predefined.NOT_YET_IMPLEMENTED;
+  }
+
   /**
    * Calculates the intrinsic gas cost based on the number of bytes in the data field.
    * Using a loop that goes through every two characters in the string it counts the zero and non-zero bytes.

packages/relay/tests/lib/precheck.spec.ts

@@ -926,4 +926,22 @@ describe('Precheck', async function () {
       );
     });
   });
+
+  describe('accessList', async function () {
+    it('should successfully parse a valid transaction string with empty access list', function () {
+      parsedTxWithMatchingChainId.accessList = [];
+      precheck.accessList(parsedTxWithMatchingChainId);
+      expect(parsedTxWithMatchingChainId.accessList).to.be.empty;
+    });
+
+    it('should throw NOT_YET_IMPLEMENTED for non-empty access list', function () {
+      parsedTxWithMatchingChainId.accessList = [
+        {
+          address: '0x67D8d32E9Bf1a9968a5ff53B87d777Aa8EBBEe69',
+          storageKeys: [],
+        },
+      ];
+      expect(() => precheck.accessList(parsedTxWithMatchingChainId)).to.throw('Not yet implemented');
+    });
+  });
 });

packages/server/tests/acceptance/sendRawTransactionExtension.spec.ts

@@ -97,6 +97,50 @@ describe('@sendRawTransactionExtension Acceptance Tests', function () {
       });
     });
 
+    describe('accessList', function () {
+      it('should fail when calling "eth_sendRawTransaction" with non-empty access list', async function () {
+        const gasPrice = await relay.gasPrice();
+        const transaction = {
+          type: 2,
+          chainId: Number(CHAIN_ID),
+          nonce: await relay.getAccountNonce(accounts[1].address),
+          maxPriorityFeePerGas: gasPrice,
+          maxFeePerGas: gasPrice,
+          gasLimit: defaultGasLimit,
+          accessList: [
+            {
+              address: '0x67D8d32E9Bf1a9968a5ff53B87d777Aa8EBBEe69',
+              storageKeys: [],
+            },
+          ],
+          to: accounts[0].address,
+        };
+
+        const signedTx = await accounts[1].wallet.signTransaction(transaction);
+        await expect(relay.sendRawTransaction(signedTx)).to.eventually.be.rejected;
+      });
+
+      it('should succeed when calling "eth_sendRawTransaction" with an empty access list', async function () {
+        const gasPrice = await relay.gasPrice();
+        const transaction = {
+          type: 2,
+          chainId: Number(CHAIN_ID),
+          nonce: await relay.getAccountNonce(accounts[1].address),
+          maxPriorityFeePerGas: gasPrice,
+          maxFeePerGas: gasPrice,
+          gasLimit: defaultGasLimit,
+          accessList: [],
+          to: accounts[0].address,
+        };
+        const signedTx = await accounts[1].wallet.signTransaction(transaction);
+        const transactionHash = await relay.sendRawTransaction(signedTx);
+        await relay.pollForValidTransactionReceipt(transactionHash);
+
+        const info = await mirrorNode.get(`/contracts/results/${transactionHash}`);
+        expect(info).to.exist;
+      });
+    });
+
     describe('callDataSize', function () {
       it('@release should execute "eth_sendRawTransaction" with regular transaction size within the CALL_DATA_SIZE_LIMIT - 128kb limit', async function () {
         const gasPrice = await relay.gasPrice();