fix: cleaned up RateLimitStoreFactory test

Signed-off-by: Logan Nguyen <[email protected]>

Author: quiet-node

packages/relay/tests/lib/services/rateLimiterService/RateLimitStoreFactory.spec.ts

@@ -16,6 +16,7 @@ describe('RateLimitStoreFactory', () => {
   let registry: Registry;
   let rateLimitStoreFailureCounter: Counter;
   const testDuration = 5000;
+  const mockRedisClient = { eval: () => {} } as any;
 
   beforeEach(() => {
     logger = pino({ level: 'silent' });
@@ -29,22 +30,12 @@ describe('RateLimitStoreFactory', () => {
   });
 
   describe('create', () => {
-    it('should return LruRateLimitStore when redisClient is not provided', () => {
-      const store = RateLimitStoreFactory.create(logger, testDuration);
-
-      expect(store).to.be.instanceOf(LruRateLimitStore);
-    });
-
     it('should return LruRateLimitStore when redisClient is undefined', () => {
       const store = RateLimitStoreFactory.create(logger, testDuration, rateLimitStoreFailureCounter, undefined);
-
       expect(store).to.be.instanceOf(LruRateLimitStore);
     });
 
     it('should return RedisRateLimitStore when redisClient is provided', () => {
-      // Mock Redis client - just needs to be a truthy object for the factory logic
-      const mockRedisClient = { eval: () => {} } as any;
-
       const store = RateLimitStoreFactory.create(logger, testDuration, rateLimitStoreFailureCounter, mockRedisClient);
 
       expect(store).to.be.instanceOf(RedisRateLimitStore);
@@ -57,30 +48,17 @@ describe('RateLimitStoreFactory', () => {
     });
 
     it('should return RedisRateLimitStore with failure counter', () => {
-      const mockRedisClient = { eval: () => {} } as any;
-
       const store = RateLimitStoreFactory.create(logger, testDuration, rateLimitStoreFailureCounter, mockRedisClient);
 
       expect(store).to.be.instanceOf(RedisRateLimitStore);
     });
 
     it('should create different store instances on multiple calls', () => {
       const store1 = RateLimitStoreFactory.create(logger, testDuration);
-      const store2 = RateLimitStoreFactory.create(logger, testDuration);
-
-      expect(store1).to.not.equal(store2);
-      expect(store1).to.be.instanceOf(LruRateLimitStore);
-      expect(store2).to.be.instanceOf(LruRateLimitStore);
-    });
-
-    it('should create different Redis store instances on multiple calls', () => {
-      const mockRedisClient = { eval: () => {} } as any;
-
-      const store1 = RateLimitStoreFactory.create(logger, testDuration, rateLimitStoreFailureCounter, mockRedisClient);
       const store2 = RateLimitStoreFactory.create(logger, testDuration, rateLimitStoreFailureCounter, mockRedisClient);
 
       expect(store1).to.not.equal(store2);
-      expect(store1).to.be.instanceOf(RedisRateLimitStore);
+      expect(store1).to.be.instanceOf(LruRateLimitStore);
       expect(store2).to.be.instanceOf(RedisRateLimitStore);
     });
   });