Calls with bad data should return an error response (#390)

* Add truffle-relay compatibility
* Add license headers
* Edit package.json
* Edit tests
* Add note
* Fix sendRawTransaction
* Add test
* Remove leftover

Signed-off-by: nikolay <[email protected]>

Author: natanasow

packages/relay/src/lib/eth.ts

@@ -657,9 +657,12 @@ export class EthImpl implements Eth {
     try {
       const gasPrice = await this.getFeeWeibars(EthImpl.ethSendRawTransaction);
       await this.precheck.sendRawTransactionCheck(transaction, gasPrice);
-    }
-    catch(e: any) {
-      return e;
+    } catch (e: any) {
+      if (e instanceof JsonRpcError) {
+        return e;
+      }
+
+      throw predefined.INTERNAL_ERROR;
     }
 
     const transactionBuffer = Buffer.from(EthImpl.prune0x(transaction), 'hex');

packages/relay/tests/lib/eth.spec.ts

@@ -1437,6 +1437,24 @@ describe('Eth calls using MirrorNode', async function () {
       expect(result).to.equal("0x00")
     });
   });
+
+  describe('eth_sendRawTransaction', async function() {
+    it('should return a predefined INTERNAL_ERROR instead of NUMERIC_FAULT as precheck exception', async function() {
+      // tx with 'gasLimit: BigNumber { value: "30678687678687676876786786876876876000" }'
+      const txHash = '0x02f881820128048459682f0086014fa0186f00901714801554cbe52dd95512bedddf68e09405fba803be258049a27b820088bab1cad205887185174876e80080c080a0cab3f53602000c9989be5787d0db637512acdd2ad187ce15ba83d10d9eae2571a07802515717a5a1c7d6fa7616183eb78307b4657d7462dbb9e9deca820dd28f62';
+
+      let hasError = false;
+      mock.onGet('network/fees').reply(200, defaultNetworkFees);
+      try {
+        await ethImpl.sendRawTransaction(txHash);
+      } catch (e) {
+        hasError = true;
+        expect(e.code).to.equal(-32603);
+        expect(e.name).to.equal('Internal error');
+      }
+      expect(hasError).to.be.true;
+    });
+  });
 });
 
 describe('Eth', async function () {