chore: cherry picked #2854 (#2859)

fix: duplicated transactions in transactions array on eth_getBlockByNumber (#2854)

* chore: remove duplicated transactions



* chore: add tests



* chore: fix typo



---------

Signed-off-by: nikolay <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Co-authored-by: Nikolay Atanasow <[email protected]>

Author: quiet-node

packages/relay/src/lib/eth.ts

@@ -2278,6 +2278,7 @@ export class EthImpl implements Eth {
     }
 
     transactionArray = this.populateSyntheticTransactions(showDetails, logs, transactionArray, requestIdPrefix);
+    transactionArray = showDetails ? _.uniqBy(transactionArray, 'hash') : _.uniq(transactionArray);
 
     const blockHash = toHash32(blockResponse.hash);
     return new Block({

packages/relay/tests/lib/eth/eth_getBlockByHash.spec.ts

@@ -123,6 +123,25 @@ describe('@ethGetBlockByHash using MirrorNode', async function () {
     });
   });
 
+  it('eth_getBlockByHash with match and duplicated transactions', async function () {
+    restMock.onGet(`blocks/${BLOCK_HASH}`).reply(200, DEFAULT_BLOCK);
+    restMock.onGet(CONTRACT_RESULTS_WITH_FILTER_URL).reply(200, {
+      results: [...defaultContractResults.results, ...defaultContractResults.results],
+    });
+    restMock.onGet('network/fees').reply(200, DEFAULT_NETWORK_FEES);
+    restMock.onGet(CONTRACT_RESULTS_LOGS_WITH_FILTER_URL).reply(200, DEFAULT_ETH_GET_BLOCK_BY_LOGS);
+
+    const res = await ethImpl.getBlockByHash(BLOCK_HASH, false);
+    RelayAssertions.assertBlock(res, {
+      transactions: [CONTRACT_HASH_1, CONTRACT_HASH_2],
+      hash: BLOCK_HASH_TRIMMED,
+      number: BLOCK_NUMBER_HEX,
+      timestamp: BLOCK_TIMESTAMP_HEX,
+      parentHash: BLOCK_HASH_PREV_TRIMMED,
+      gasUsed: TOTAL_GAS_USED,
+    });
+  });
+
   it('eth_getBlockByHash with match and valid logsBloom field', async function () {
     // mirror node request mocks
     restMock.onGet(`blocks/${BLOCK_HASH}`).reply(200, {

packages/relay/tests/lib/eth/eth_getBlockByNumber.spec.ts

@@ -226,6 +226,22 @@ describe('@ethGetBlockByNumber using MirrorNode', async function () {
       });
     });
 
+    it('eth_getBlockByNumber with match and duplicated transactions', async function () {
+      restMock.onGet(CONTRACT_RESULTS_WITH_FILTER_URL).reply(200, {
+        results: [...defaultContractResults.results, ...defaultContractResults.results],
+      });
+
+      const res = await ethImpl.getBlockByNumber(numberTo0x(BLOCK_NUMBER), false);
+      RelayAssertions.assertBlock(res, {
+        transactions: [CONTRACT_HASH_1, CONTRACT_HASH_2],
+        hash: BLOCK_HASH_TRIMMED,
+        number: BLOCK_NUMBER_HEX,
+        timestamp: BLOCK_TIMESTAMP_HEX,
+        parentHash: BLOCK_HASH_PREV_TRIMMED,
+        gasUsed: TOTAL_GAS_USED,
+      });
+    });
+
     it('eth_getBlockByNumber with match and valid logsBloom field', async function () {
       restMock.onGet(`blocks/${BLOCK_NUMBER}`).reply(200, {
         ...DEFAULT_BLOCK,