Use evm_address of recently deployed contracts to populate the transaction receipt result (#766)

* Edit getTransactionReceipt

Signed-off-by: nikolay <[email protected]>

* Fix code smell

Signed-off-by: nikolay <[email protected]>

Signed-off-by: nikolay <[email protected]>

Author: natanasow

packages/relay/src/lib/eth.ts

@@ -19,7 +19,7 @@
  */
 
 import { Eth } from '../index';
-import { ContractId, Hbar, EthereumTransaction } from '@hashgraph/sdk';
+import { Hbar, EthereumTransaction } from '@hashgraph/sdk';
 import { BigNumber } from '@hashgraph/sdk/lib/Transfer';
 import { Logger } from 'pino';
 import { Block, Transaction, Log } from './model';
@@ -1033,12 +1033,6 @@ export class EthImpl implements Eth {
           ? receiptResponse.gas_price
           : receiptResponse.max_fee_per_gas;
 
-      let createdContract;
-      if (receiptResponse.created_contract_ids.length) {
-        const contract = await this.mirrorNodeClient.getContract(receiptResponse.created_contract_ids[0]);
-        createdContract = contract?.evm_address ?? EthImpl.prepend0x(ContractId.fromString(receiptResponse.created_contract_ids[0]).toSolidityAddress());
-      }
-
       // support stricter go-eth client which requires the transaction hash property on logs
       const logs = receiptResponse.logs.map(log => {
         return new Log({
@@ -1061,7 +1055,7 @@ export class EthImpl implements Eth {
         to: receiptResponse.to,
         cumulativeGasUsed: EthImpl.numberTo0x(receiptResponse.block_gas_used),
         gasUsed: EthImpl.nanOrNumberTo0x(receiptResponse.gas_used),
-        contractAddress: createdContract,
+        contractAddress: receiptResponse.address,
         logs: logs,
         logsBloom: receiptResponse.bloom === EthImpl.emptyHex ? EthImpl.emptyBloom : receiptResponse.bloom,
         transactionHash: EthImpl.toHash32(receiptResponse.hash),

packages/relay/tests/lib/eth.spec.ts

@@ -2530,6 +2530,7 @@ describe('Eth', async function () {
   };
 
   const defaultDetailedContractResultByHash = {
+    "address": "0xd8db0b1dbf8ba6721ef5256ad5fe07d72d1d04b9",
     "amount": 2000000000,
     "bloom":
       "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
@@ -2611,7 +2612,7 @@ describe('Eth', async function () {
     "status": "0x1",
     "transactionHash": "0x4a563af33c4871b51a8b108aa2fe1dd5280a30dfb7236170ae5e5e7957eb6392",
     "transactionIndex": "0x1",
-    "contractAddress": "0x0000000000000000000000000000000000001b59",
+    "contractAddress": "0xd8db0b1dbf8ba6721ef5256ad5fe07d72d1d04b9",
     "root": undefined
   };