936 block number range test (#1279)

* 936 Added a max block number range.
Signed-off-by: ebadiere <[email protected]>

* Removed .only.

Signed-off-by: ebadiere <[email protected]>

* Added !EthImpl.blockTagIsLatestOrPending(blockNumberOrTag) to the max block evaluation.

Signed-off-by: ebadiere <[email protected]>

* Added passing conditions to the latest block test.

Signed-off-by: ebadiere <[email protected]>

* Applied suggested update.

Signed-off-by: ebadiere <[email protected]>

* Fixed sonar issue.

Signed-off-by: ebadiere <[email protected]>

---------

Signed-off-by: ebadiere <[email protected]>

Author: ebadiere

packages/relay/src/lib/eth.ts

@@ -1609,7 +1609,8 @@ export class EthImpl implements Eth {
       return null;
     }
 
-    if (blockNumberOrTag != null && blockNumberOrTag.length < 32 && !EthImpl.blockTagIsEarliestOrPending(blockNumberOrTag)) {
+    const blockNumber = Number(blockNumberOrTag);
+    if (blockNumberOrTag != null && blockNumberOrTag.length < 32 && !isNaN(blockNumber)) {
       const latestBlockResponse = await this.mirrorNodeClient.getLatestBlock(requestId);
       const latestBlock = latestBlockResponse.blocks[0];
       if (Number(blockNumberOrTag) > latestBlock.number + maxBlockRange) {

packages/relay/tests/lib/eth.spec.ts

@@ -998,6 +998,12 @@ describe('Eth calls using MirrorNode', async function () {
     expect(result).to.exist;
     if (result == null) return;
 
+    // check that we only made the expected number of requests with the expected urls
+    expect(restMock.history.get.length).equal(3);
+    expect(restMock.history.get[0].url).equal('blocks?limit=1&order=desc');
+    expect(restMock.history.get[1].url).equal('contracts/results?timestamp=gte:1651560386.060890949&timestamp=lte:1651560389.060890949&limit=100&order=asc');
+    expect(restMock.history.get[2].url).equal('network/fees');
+
     expect(result.number).equal(blockNumberHex);
   });