fix: fixes check to remove duplicates from transactionArray (#3731)

Signed-off-by: Simeon Nakov <[email protected]>

Author: simzzz

packages/relay/src/lib/eth.ts

@@ -2881,6 +2881,7 @@ export class EthImpl implements Eth {
       );
     }
 
+    transactionsArray = _.uniqWith(transactionsArray, _.isEqual);
     return transactionsArray;
   }
 
@@ -2948,8 +2949,6 @@ export class EthImpl implements Eth {
     }
 
     transactionArray = this.populateSyntheticTransactions(showDetails, logs, transactionArray, requestDetails);
-    transactionArray = showDetails ? transactionArray : _.uniq(transactionArray);
-
     const formattedReceipts: IReceiptRootHash[] = ReceiptsRootUtils.buildReceiptRootHashes(
       transactionArray.map((tx) => (showDetails ? tx.hash : tx)),
       contractResults,

packages/relay/tests/lib/ethGetBlockBy.spec.ts

@@ -277,5 +277,20 @@ describe('eth_getBlockBy', async function () {
       expect(txObjects[1].hash).to.equal(modelLog2.transactionHash);
       expect(txObjects[2].hash).to.equal(modelLog3.transactionHash);
     });
+
+    it('deduplicates duplicate transaction objects in the result', async function () {
+      const tx1 = getTransactionModel(modelLog1.transactionHash);
+      const tx2 = getTransactionModel(modelLog1.transactionHash); // duplicate hash, different object
+      const initTxObjects = [tx1, tx2];
+
+      const txObjects = initTxObjects.slice();
+      const returnedTxObjects = ethImpl.populateSyntheticTransactions(true, referenceLogs, txObjects, requestDetails);
+
+      // Should only have one object with modelLog1.transactionHash
+      const count = returnedTxObjects.filter((tx) => tx.hash === modelLog1.transactionHash).length;
+      expect(count).to.equal(1);
+
+      expect(returnedTxObjects.length).to.equal(referenceLogs.length);
+    });
   });
 });